chrome/browser/drive/drive_notification_manager.cc - Issue 1146533005: [Sync] InvalidationService shouldn't CHECK when registering ObjectId for more than one handler

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/drive/drive_notification_manager.cc

Issue 1146533005: [Sync] InvalidationService shouldn't CHECK when registering ObjectId for more than one handler (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comments from Bartosz. Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/drive/drive_notification_manager.cc

diff --git a/chrome/browser/drive/drive_notification_manager.cc b/chrome/browser/drive/drive_notification_manager.cc

index 0ba122b704971712b2192a02a2f4be862bd6a461..b25d2be6a42a95573bbbf9ffe67c7ab1669dcd48 100644

--- a/chrome/browser/drive/drive_notification_manager.cc

+++ b/chrome/browser/drive/drive_notification_manager.cc

@@ -135,7 +135,7 @@ void DriveNotificationManager::RegisterDriveNotifications() {

ids.insert(invalidation::ObjectId(

ipc::invalidation::ObjectSource::COSMO_CHANGELOG,

kDriveInvalidationObjectId));

- invalidation_service_->UpdateRegisteredInvalidationIds(this, ids);

+ CHECK(invalidation_service_->UpdateRegisteredInvalidationIds(this, ids));

push_notification_registered_ = true;

OnInvalidatorStateChange(invalidation_service_->GetInvalidatorState());

« no previous file with comments | « no previous file | chrome/browser/invalidation/fake_invalidation_service.h » ('j') | no next file with comments »