components/invalidation/fake_invalidator.cc - Issue 1146533005: [Sync] InvalidationService shouldn't CHECK when registering ObjectId for more than one handler

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/invalidation/fake_invalidator.cc

Issue 1146533005: [Sync] InvalidationService shouldn't CHECK when registering ObjectId for more than one handler (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/invalidation/fake_invalidator.h ('k') | components/invalidation/invalidation_notifier.h » ('j') | components/invalidation/invalidation_service_test_template.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/invalidation/fake_invalidator.cc

diff --git a/components/invalidation/fake_invalidator.cc b/components/invalidation/fake_invalidator.cc

index 00bbc87b7afeb4a591637c82cebac2f28e59195b..d82c3972e36173224a87dc9ad3246f62ac242858 100644

--- a/components/invalidation/fake_invalidator.cc

+++ b/components/invalidation/fake_invalidator.cc

@@ -42,9 +42,9 @@ void FakeInvalidator::RegisterHandler(InvalidationHandler* handler) {

registrar_.RegisterHandler(handler);

}

-void FakeInvalidator::UpdateRegisteredIds(InvalidationHandler* handler,

+bool FakeInvalidator::UpdateRegisteredIds(InvalidationHandler* handler,

const ObjectIdSet& ids) {

- registrar_.UpdateRegisteredIds(handler, ids);

+ return registrar_.UpdateRegisteredIds(handler, ids);

}

void FakeInvalidator::UnregisterHandler(InvalidationHandler* handler) {