Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Side by Side Diff: components/invalidation/ticl_invalidation_service.h

Issue 1146533005: [Sync] InvalidationService shouldn't CHECK when registering ObjectId for more than one handler (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed comments from Bartosz. Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_INVALIDATION_TICL_INVALIDATION_SERVICE_H_ 5 #ifndef COMPONENTS_INVALIDATION_TICL_INVALIDATION_SERVICE_H_
6 #define COMPONENTS_INVALIDATION_TICL_INVALIDATION_SERVICE_H_ 6 #define COMPONENTS_INVALIDATION_TICL_INVALIDATION_SERVICE_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/compiler_specific.h" 10 #include "base/compiler_specific.h"
(...skipping 56 matching lines...) Expand 10 before | Expand all | Expand 10 after
67 const scoped_refptr<net::URLRequestContextGetter>& request_context); 67 const scoped_refptr<net::URLRequestContextGetter>& request_context);
68 ~TiclInvalidationService() override; 68 ~TiclInvalidationService() override;
69 69
70 void Init( 70 void Init(
71 scoped_ptr<syncer::InvalidationStateTracker> invalidation_state_tracker); 71 scoped_ptr<syncer::InvalidationStateTracker> invalidation_state_tracker);
72 72
73 // InvalidationService implementation. 73 // InvalidationService implementation.
74 // It is an error to have registered handlers when the service is destroyed. 74 // It is an error to have registered handlers when the service is destroyed.
75 void RegisterInvalidationHandler( 75 void RegisterInvalidationHandler(
76 syncer::InvalidationHandler* handler) override; 76 syncer::InvalidationHandler* handler) override;
77 void UpdateRegisteredInvalidationIds(syncer::InvalidationHandler* handler, 77 bool UpdateRegisteredInvalidationIds(syncer::InvalidationHandler* handler,
78 const syncer::ObjectIdSet& ids) override; 78 const syncer::ObjectIdSet& ids) override;
79 void UnregisterInvalidationHandler( 79 void UnregisterInvalidationHandler(
80 syncer::InvalidationHandler* handler) override; 80 syncer::InvalidationHandler* handler) override;
81 syncer::InvalidatorState GetInvalidatorState() const override; 81 syncer::InvalidatorState GetInvalidatorState() const override;
82 std::string GetInvalidatorClientId() const override; 82 std::string GetInvalidatorClientId() const override;
83 InvalidationLogger* GetInvalidationLogger() override; 83 InvalidationLogger* GetInvalidationLogger() override;
84 void RequestDetailedStatus( 84 void RequestDetailedStatus(
85 base::Callback<void(const base::DictionaryValue&)> caller) const override; 85 base::Callback<void(const base::DictionaryValue&)> caller) const override;
86 IdentityProvider* GetIdentityProvider() override; 86 IdentityProvider* GetIdentityProvider() override;
87 87
(...skipping 71 matching lines...) Expand 10 before | Expand all | Expand 10 after
159 // Keep a copy of the important parameters used in network channel creation 159 // Keep a copy of the important parameters used in network channel creation
160 // for debugging. 160 // for debugging.
161 base::DictionaryValue network_channel_options_; 161 base::DictionaryValue network_channel_options_;
162 162
163 DISALLOW_COPY_AND_ASSIGN(TiclInvalidationService); 163 DISALLOW_COPY_AND_ASSIGN(TiclInvalidationService);
164 }; 164 };
165 165
166 } // namespace invalidation 166 } // namespace invalidation
167 167
168 #endif // COMPONENTS_INVALIDATION_TICL_INVALIDATION_SERVICE_H_ 168 #endif // COMPONENTS_INVALIDATION_TICL_INVALIDATION_SERVICE_H_
OLDNEW
« no previous file with comments | « components/invalidation/p2p_invalidator.cc ('k') | components/invalidation/ticl_invalidation_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698