Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Side by Side Diff: components/invalidation/invalidation_service_android.h

Issue 1146533005: [Sync] InvalidationService shouldn't CHECK when registering ObjectId for more than one handler (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed comments from Bartosz. Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_INVALIDATION_INVALIDATION_SERVICE_ANDROID_H_ 5 #ifndef COMPONENTS_INVALIDATION_INVALIDATION_SERVICE_ANDROID_H_
6 #define COMPONENTS_INVALIDATION_INVALIDATION_SERVICE_ANDROID_H_ 6 #define COMPONENTS_INVALIDATION_INVALIDATION_SERVICE_ANDROID_H_
7 7
8 #include <jni.h> 8 #include <jni.h>
9 #include <map> 9 #include <map>
10 10
(...skipping 21 matching lines...) Expand all
32 InvalidationServiceAndroid(jobject context); 32 InvalidationServiceAndroid(jobject context);
33 ~InvalidationServiceAndroid() override; 33 ~InvalidationServiceAndroid() override;
34 34
35 // InvalidationService implementation. 35 // InvalidationService implementation.
36 // 36 //
37 // Note that this implementation does not properly support Ack-tracking, 37 // Note that this implementation does not properly support Ack-tracking,
38 // fetching the invalidator state, or querying the client's ID. Support for 38 // fetching the invalidator state, or querying the client's ID. Support for
39 // exposing the client ID should be available soon; see crbug.com/172391. 39 // exposing the client ID should be available soon; see crbug.com/172391.
40 void RegisterInvalidationHandler( 40 void RegisterInvalidationHandler(
41 syncer::InvalidationHandler* handler) override; 41 syncer::InvalidationHandler* handler) override;
42 void UpdateRegisteredInvalidationIds(syncer::InvalidationHandler* handler, 42 bool UpdateRegisteredInvalidationIds(syncer::InvalidationHandler* handler,
43 const syncer::ObjectIdSet& ids) override; 43 const syncer::ObjectIdSet& ids) override;
44 void UnregisterInvalidationHandler( 44 void UnregisterInvalidationHandler(
45 syncer::InvalidationHandler* handler) override; 45 syncer::InvalidationHandler* handler) override;
46 syncer::InvalidatorState GetInvalidatorState() const override; 46 syncer::InvalidatorState GetInvalidatorState() const override;
47 std::string GetInvalidatorClientId() const override; 47 std::string GetInvalidatorClientId() const override;
48 InvalidationLogger* GetInvalidationLogger() override; 48 InvalidationLogger* GetInvalidationLogger() override;
49 void RequestDetailedStatus( 49 void RequestDetailedStatus(
50 base::Callback<void(const base::DictionaryValue&)> caller) const override; 50 base::Callback<void(const base::DictionaryValue&)> caller) const override;
51 IdentityProvider* GetIdentityProvider() override; 51 IdentityProvider* GetIdentityProvider() override;
52 52
(...skipping 38 matching lines...) Expand 10 before | Expand all | Expand 10 after
91 91
92 void DispatchInvalidations( 92 void DispatchInvalidations(
93 syncer::ObjectIdInvalidationMap& object_invalidation_map); 93 syncer::ObjectIdInvalidationMap& object_invalidation_map);
94 94
95 DISALLOW_COPY_AND_ASSIGN(InvalidationServiceAndroid); 95 DISALLOW_COPY_AND_ASSIGN(InvalidationServiceAndroid);
96 }; 96 };
97 97
98 } // namespace invalidation 98 } // namespace invalidation
99 99
100 #endif // COMPONENTS_INVALIDATION_INVALIDATION_SERVICE_ANDROID_H_ 100 #endif // COMPONENTS_INVALIDATION_INVALIDATION_SERVICE_ANDROID_H_
OLDNEW
« no previous file with comments | « components/invalidation/invalidation_service.h ('k') | components/invalidation/invalidation_service_android.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698