Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Side by Side Diff: components/invalidation/invalidation_notifier.h

Issue 1146533005: [Sync] InvalidationService shouldn't CHECK when registering ObjectId for more than one handler (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed comments from Bartosz. Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 // 4 //
5 // An implementation of Invalidator that wraps an invalidation 5 // An implementation of Invalidator that wraps an invalidation
6 // client. Handles the details of connecting to XMPP and hooking it 6 // client. Handles the details of connecting to XMPP and hooking it
7 // up to the invalidation client. 7 // up to the invalidation client.
8 // 8 //
9 // You probably don't want to use this directly; use 9 // You probably don't want to use this directly; use
10 // NonBlockingInvalidator. 10 // NonBlockingInvalidator.
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
47 const std::string& invalidation_bootstrap_data, 47 const std::string& invalidation_bootstrap_data,
48 const base::WeakPtr<InvalidationStateTracker>& invalidation_state_tracker, 48 const base::WeakPtr<InvalidationStateTracker>& invalidation_state_tracker,
49 scoped_refptr<base::SingleThreadTaskRunner> 49 scoped_refptr<base::SingleThreadTaskRunner>
50 invalidation_state_tracker_task_runner, 50 invalidation_state_tracker_task_runner,
51 const std::string& client_info); 51 const std::string& client_info);
52 52
53 ~InvalidationNotifier() override; 53 ~InvalidationNotifier() override;
54 54
55 // Invalidator implementation. 55 // Invalidator implementation.
56 void RegisterHandler(InvalidationHandler* handler) override; 56 void RegisterHandler(InvalidationHandler* handler) override;
57 void UpdateRegisteredIds(InvalidationHandler* handler, 57 bool UpdateRegisteredIds(InvalidationHandler* handler,
58 const ObjectIdSet& ids) override; 58 const ObjectIdSet& ids) override;
59 void UnregisterHandler(InvalidationHandler* handler) override; 59 void UnregisterHandler(InvalidationHandler* handler) override;
60 InvalidatorState GetInvalidatorState() const override; 60 InvalidatorState GetInvalidatorState() const override;
61 void UpdateCredentials(const std::string& email, 61 void UpdateCredentials(const std::string& email,
62 const std::string& token) override; 62 const std::string& token) override;
63 void RequestDetailedStatus(base::Callback<void(const base::DictionaryValue&)> 63 void RequestDetailedStatus(base::Callback<void(const base::DictionaryValue&)>
64 callback) const override; 64 callback) const override;
65 65
66 // SyncInvalidationListener::Delegate implementation. 66 // SyncInvalidationListener::Delegate implementation.
67 void OnInvalidate(const ObjectIdInvalidationMap& invalidation_map) override; 67 void OnInvalidate(const ObjectIdInvalidationMap& invalidation_map) override;
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
100 100
101 // The invalidation listener. 101 // The invalidation listener.
102 SyncInvalidationListener invalidation_listener_; 102 SyncInvalidationListener invalidation_listener_;
103 103
104 DISALLOW_COPY_AND_ASSIGN(InvalidationNotifier); 104 DISALLOW_COPY_AND_ASSIGN(InvalidationNotifier);
105 }; 105 };
106 106
107 } // namespace syncer 107 } // namespace syncer
108 108
109 #endif // COMPONENTS_INVALIDATION_INVALIDATION_NOTIFIER_H_ 109 #endif // COMPONENTS_INVALIDATION_INVALIDATION_NOTIFIER_H_
OLDNEW
« no previous file with comments | « components/invalidation/fake_invalidator.cc ('k') | components/invalidation/invalidation_notifier.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698