Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Issue 1146533003: Add SpdyFramer methods for SETTINGS_HEADER_TABLE_SIZE. (Closed)

Created:
5 years, 7 months ago by Bence
Modified:
5 years, 7 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add SpdyFramer methods for SETTINGS_HEADER_TABLE_SIZE. This CL lands server change 90723544 by yinjie. BUG=488484 Committed: https://crrev.com/0dfba7c54f227ba78242da91b4c8ac2033102f26 Cr-Commit-Position: refs/heads/master@{#330161}

Patch Set 1 #

Patch Set 2 : Remove const qualifier from size_t return type. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -1 line) Patch
M net/spdy/spdy_framer.h View 1 2 chunks +9 lines, -0 lines 0 comments Download
M net/spdy/spdy_framer.cc View 1 2 chunks +13 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Bence
Ryan: PTAL. Thanks.
5 years, 7 months ago (2015-05-15 18:23:29 UTC) #3
Ryan Hamilton
lgtm
5 years, 7 months ago (2015-05-15 18:47:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1146533003/40001
5 years, 7 months ago (2015-05-15 19:14:13 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:40001)
5 years, 7 months ago (2015-05-15 19:24:55 UTC) #7
commit-bot: I haz the power
5 years, 7 months ago (2015-05-15 19:25:53 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0dfba7c54f227ba78242da91b4c8ac2033102f26
Cr-Commit-Position: refs/heads/master@{#330161}

Powered by Google App Engine
This is Rietveld 408576698