Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 1146523005: cc: Remove LTHCommon temporary property trees (Closed)

Created:
5 years, 7 months ago by enne (OOO)
Modified:
5 years, 7 months ago
Reviewers:
Ian Vollick, ajuma
CC:
cc-bugs_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Remove LTHCommon temporary property trees This was a missing part of putting property trees on the compositor thread. Because these temporary property trees are being used instead of the ones on LayerTreeImpl, it makes future calls that touch property trees through LayerImpls have bogus indices because the trees on the LayerTreeImpl are not the same as the temporary property trees. R=ajuma@chromium.org,vollick@chromium.org BUG=481585 Committed: https://crrev.com/2b192b9ffe79f7cbe022f377a2cda7f6df94446f Cr-Commit-Position: refs/heads/master@{#330621}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -14 lines) Patch
M cc/trees/layer_tree_host_common.h View 4 chunks +4 lines, -9 lines 0 comments Download
M cc/trees/layer_tree_host_common.cc View 1 chunk +3 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
enne (OOO)
5 years, 7 months ago (2015-05-19 20:14:30 UTC) #1
ajuma
lgtm
5 years, 7 months ago (2015-05-19 20:24:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1146523005/1
5 years, 7 months ago (2015-05-19 20:43:01 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-19 21:52:58 UTC) #5
commit-bot: I haz the power
5 years, 7 months ago (2015-05-19 21:54:06 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2b192b9ffe79f7cbe022f377a2cda7f6df94446f
Cr-Commit-Position: refs/heads/master@{#330621}

Powered by Google App Engine
This is Rietveld 408576698