Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(419)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1146503003: fixes #183, remove our InMemory* in favor of analyzer's impl (Closed)

Created:
5 years, 7 months ago by Jennifer Messerly
Modified:
5 years, 7 months ago
CC:
dev-compiler+reviews_dartlang.org
Base URL:
git@github.com:dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

fixes #183, remove our InMemory* in favor of analyzer's impl this should improve test coverage too, as analyzer's MemoryResourceProvider/ResourceUriResolver matches the real semantics more closely than ours did. R=sigmund@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/644e5b5b0ca667a961b29f7301d118a0f357b36c

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+187 lines, -257 lines) Patch
M lib/src/checker/resolver.dart View 3 chunks +5 lines, -3 lines 0 comments Download
M lib/src/dependency_graph.dart View 6 chunks +14 lines, -12 lines 0 comments Download
D lib/src/in_memory.dart View 1 chunk +0 lines, -94 lines 0 comments Download
M lib/src/testing.dart View 7 chunks +58 lines, -23 lines 0 comments Download
M lib/src/utils.dart View 1 chunk +5 lines, -0 lines 0 comments Download
M test/dependency_graph_test.dart View 41 chunks +99 lines, -122 lines 0 comments Download
M test/runtime/dart_runtime_test.dart View 2 chunks +6 lines, -3 lines 1 comment Download

Messages

Total messages: 4 (1 generated)
Jennifer Messerly
https://codereview.chromium.org/1146503003/diff/1/test/runtime/dart_runtime_test.dart File test/runtime/dart_runtime_test.dart (right): https://codereview.chromium.org/1146503003/diff/1/test/runtime/dart_runtime_test.dart#newcode13 test/runtime/dart_runtime_test.dart:13: final bool doubleIsNonNullable = formatted this file by accident. ...
5 years, 7 months ago (2015-05-15 18:12:14 UTC) #2
Siggi Cherem (dart-lang)
lgtm, very nice
5 years, 7 months ago (2015-05-15 18:16:35 UTC) #3
Jennifer Messerly
5 years, 7 months ago (2015-05-15 18:17:31 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
644e5b5b0ca667a961b29f7301d118a0f357b36c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698