chrome/browser/extensions/extension_service.cc - Issue 11465016: Dedupe code in SetIdleInstallInfo(), FinishIdleInstallInfo() and OnExtensionInstalled().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_service.cc

Issue 11465016: Dedupe code in SetIdleInstallInfo(), FinishIdleInstallInfo() and OnExtensionInstalled(). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix logic bug and add comment. Created 8 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/extensions/extension_service.cc

diff --git a/chrome/browser/extensions/extension_service.cc b/chrome/browser/extensions/extension_service.cc

index 6ca023859a6f4daf4920098af5aa838332581882..6d2dea50993cfb1588df200afbd45b4b2640e5f2 100644

--- a/chrome/browser/extensions/extension_service.cc

+++ b/chrome/browser/extensions/extension_service.cc

@@ -2460,7 +2460,8 @@ void ExtensionService::OnExtensionInstalled(

if (ShouldDelayExtensionUpdate(id, wait_for_idle)) {

extension_prefs_->SetIdleInstallInfo(

extension,

- initial_enable ? Extension::ENABLED : Extension::DISABLED);

+ initial_enable ? Extension::ENABLED : Extension::DISABLED,

+ page_ordinal);

// Transfer ownership of |extension|.

pending_extension_updates_.Insert(extension);

« no previous file with comments | « chrome/browser/extensions/extension_prefs_unittest.cc ('k') | no next file » | no next file with comments »