Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 11465011: Preparing cc for the removal of scoped_refptr::release() (Closed)

Created:
8 years ago by piman
Modified:
8 years ago
Reviewers:
jamesr
CC:
chromium-reviews, cc-bugs_chromium.org
Visibility:
Public.

Description

Preparing cc for the removal of scoped_refptr::release() BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=171660

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M cc/occlusion_tracker_unittest.cc View 1 chunk +6 lines, -2 lines 1 comment Download

Messages

Total messages: 4 (0 generated)
piman
https://codereview.chromium.org/11465011/diff/1/cc/occlusion_tracker_unittest.cc File cc/occlusion_tracker_unittest.cc (right): https://codereview.chromium.org/11465011/diff/1/cc/occlusion_tracker_unittest.cc#newcode138 cc/occlusion_tracker_unittest.cc:138: layer = NULL; Note: Dana suggested skipping the resetting ...
8 years ago (2012-12-06 21:07:48 UTC) #1
jamesr
Seems unfortunately verbose, but oh well lgtm
8 years ago (2012-12-06 22:00:21 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/piman@chromium.org/11465011/1
8 years ago (2012-12-06 22:35:59 UTC) #3
commit-bot: I haz the power
8 years ago (2012-12-07 00:50:22 UTC) #4
Message was sent while issue was closed.
Change committed as 171660

Powered by Google App Engine
This is Rietveld 408576698