Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(817)

Issue 1146463002: Reland: Show the eject button only for removables and file handlers. (Closed)

Created:
5 years, 7 months ago by mtomasz
Modified:
5 years, 7 months ago
Reviewers:
benwells, hirono
CC:
chromium-reviews, extensions-reviews_chromium.org, tzik, nhiroki, rginda+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, kinuko+fileapi, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland: Add the chrome.fileSystem.onVolumeListChanged event. This CL adds an event which notifies extension about changed list of volumes which can be requested via chrome.fileSystem.requestFileSystem. TBR=benwells@chromium.org TEST=browser_tests: *OnVolumeListChanged* BUG=440674 Committed: https://crrev.com/c314676fbb9b81b7450aeec1a803b872a2f34f2a Cr-Commit-Position: refs/heads/master@{#330073}

Patch Set 1 : Original (broken) CL. #

Total comments: 1

Patch Set 2 : Fixed. #

Messages

Total messages: 9 (3 generated)
mtomasz
https://codereview.chromium.org/1146463002/diff/20001/chrome/browser/extensions/api/file_system/file_system_api.cc File chrome/browser/extensions/api/file_system/file_system_api.cc (right): https://codereview.chromium.org/1146463002/diff/20001/chrome/browser/extensions/api/file_system/file_system_api.cc#newcode322 chrome/browser/extensions/api/file_system/file_system_api.cc:322: new ConsentProviderDelegate(profile, nullptr)); This was causing a leak, as ...
5 years, 7 months ago (2015-05-15 09:14:34 UTC) #3
hirono
lgtm
5 years, 7 months ago (2015-05-15 09:29:03 UTC) #4
mtomasz
Thanks!
5 years, 7 months ago (2015-05-15 09:32:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1146463002/30001
5 years, 7 months ago (2015-05-15 09:32:11 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:30001)
5 years, 7 months ago (2015-05-15 10:48:16 UTC) #8
commit-bot: I haz the power
5 years, 7 months ago (2015-05-15 10:49:06 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c314676fbb9b81b7450aeec1a803b872a2f34f2a
Cr-Commit-Position: refs/heads/master@{#330073}

Powered by Google App Engine
This is Rietveld 408576698