Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(535)

Unified Diff: ash/wm/workspace_controller.cc

Issue 114643003: Use a single ToplevelWindowEventHandler for the ash::Shell (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/wm/workspace/workspace_event_handler_unittest.cc ('k') | tools/metrics/actions/chromeactions.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/wm/workspace_controller.cc
diff --git a/ash/wm/workspace_controller.cc b/ash/wm/workspace_controller.cc
index 1b9fd854a17d4eee88015747dba50dfd2588e0e2..54891c7fae5680644ae0df21a0b1b3dd9beb85e9 100644
--- a/ash/wm/workspace_controller.cc
+++ b/ash/wm/workspace_controller.cc
@@ -42,21 +42,18 @@ bool IsDockedAreaVisible(const ShelfLayoutManager* shelf) {
WorkspaceController::WorkspaceController(aura::Window* viewport)
: viewport_(viewport),
shelf_(NULL),
- event_handler_(new WorkspaceEventHandler(viewport_)) {
+ event_handler_(new WorkspaceEventHandler),
+ layout_manager_(new WorkspaceLayoutManager(viewport)) {
SetWindowVisibilityAnimationTransition(
viewport_, views::corewm::ANIMATE_NONE);
- // The layout-manager cannot be created in the initializer list since it
- // depends on the window to have been initialized.
- layout_manager_ = new WorkspaceLayoutManager(viewport_);
viewport_->SetLayoutManager(layout_manager_);
-
- viewport_->Show();
+ viewport_->AddPreTargetHandler(event_handler_.get());
+ viewport_->AddPostTargetHandler(event_handler_.get());
}
WorkspaceController::~WorkspaceController() {
viewport_->SetLayoutManager(NULL);
- viewport_->SetEventFilter(NULL);
viewport_->RemovePreTargetHandler(event_handler_.get());
viewport_->RemovePostTargetHandler(event_handler_.get());
}
« no previous file with comments | « ash/wm/workspace/workspace_event_handler_unittest.cc ('k') | tools/metrics/actions/chromeactions.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698