Use a single ToplevelWindowEventHandler for the ash::Shell

ash/wm/panels/panel_window_event_handler.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/wm/panels/panel_window_event_handler.h"
 
 #include "ash/wm/window_state.h"
 #include "ui/aura/window.h"
 #include "ui/aura/window_delegate.h"
 #include "ui/base/hit_test.h"
 #include "ui/events/event.h"
 
 namespace ash {
 namespace internal {
 
-PanelWindowEventHandler::PanelWindowEventHandler(aura::Window* owner)
-    : ToplevelWindowEventHandler(owner) {
+PanelWindowEventHandler::PanelWindowEventHandler() {
 }
 
 PanelWindowEventHandler::~PanelWindowEventHandler() {
 }
 
 void PanelWindowEventHandler::OnMouseEvent(ui::MouseEvent* event) {
   aura::Window* target = static_cast<aura::Window*>(event->target());
   if (event->type() == ui::ET_MOUSE_PRESSED &&
       event->flags() & ui::EF_IS_DOUBLE_CLICK &&

[varkha, 2013/12/13 04:05:14]

Do we know if this way of minimizing panels is popular or used? It makes panels
work differently and is a bit redundant with the minimize button also in place. 

[pkotwicz, 2013/12/13 20:28:42]

Added some UMA stats. With the UMA stats hopefully we can make an informed
decision about removing this feature. (At the very least this is inconsistent
with panels which not minimize when double clicked)

       event->IsOnlyLeftMouseButton() &&
       target->delegate()->GetNonClientComponent(event->location()) ==
           HTCAPTION) {
     wm::GetWindowState(target)->Minimize();
+    event->StopPropagation();
     return;
   }
-  ToplevelWindowEventHandler::OnMouseEvent(event);
 }
 
 void PanelWindowEventHandler::OnGestureEvent(ui::GestureEvent* event) {
   aura::Window* target = static_cast<aura::Window*>(event->target());
   if (event->type() == ui::ET_GESTURE_TAP &&
       event->details().tap_count() == 2 &&
       target->delegate()->GetNonClientComponent(event->location()) ==
           HTCAPTION) {
     wm::GetWindowState(target)->Minimize();
     event->StopPropagation();
     return;
   }
-  ToplevelWindowEventHandler::OnGestureEvent(event);
 }
 
 }  // namespace internal
 }  // namespace ash