Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Side by Side Diff: src/objects-inl.h

Issue 1146423002: Remove obsolete JSFunction::IsOptimizable predicate. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fix assertion. Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/objects.cc ('k') | src/runtime-profiler.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 // 4 //
5 // Review notes: 5 // Review notes:
6 // 6 //
7 // - The use of macros in these inline functions may seem superfluous 7 // - The use of macros in these inline functions may seem superfluous
8 // but it is absolutely needed to make sure gcc generates optimal 8 // but it is absolutely needed to make sure gcc generates optimal
9 // code. gcc is not happy when attempting to inline too deep. 9 // code. gcc is not happy when attempting to inline too deep.
10 // 10 //
(...skipping 6004 matching lines...) Expand 10 before | Expand all | Expand 10 after
6015 return shared()->internal_formal_parameter_count() != 6015 return shared()->internal_formal_parameter_count() !=
6016 SharedFunctionInfo::kDontAdaptArgumentsSentinel; 6016 SharedFunctionInfo::kDontAdaptArgumentsSentinel;
6017 } 6017 }
6018 6018
6019 6019
6020 bool JSFunction::IsOptimized() { 6020 bool JSFunction::IsOptimized() {
6021 return code()->kind() == Code::OPTIMIZED_FUNCTION; 6021 return code()->kind() == Code::OPTIMIZED_FUNCTION;
6022 } 6022 }
6023 6023
6024 6024
6025 bool JSFunction::IsOptimizable() {
6026 return code()->kind() == Code::FUNCTION && !shared()->optimization_disabled();
6027 }
6028
6029
6030 bool JSFunction::IsMarkedForOptimization() { 6025 bool JSFunction::IsMarkedForOptimization() {
6031 return code() == GetIsolate()->builtins()->builtin( 6026 return code() == GetIsolate()->builtins()->builtin(
6032 Builtins::kCompileOptimized); 6027 Builtins::kCompileOptimized);
6033 } 6028 }
6034 6029
6035 6030
6036 bool JSFunction::IsMarkedForConcurrentOptimization() { 6031 bool JSFunction::IsMarkedForConcurrentOptimization() {
6037 return code() == GetIsolate()->builtins()->builtin( 6032 return code() == GetIsolate()->builtins()->builtin(
6038 Builtins::kCompileOptimizedConcurrent); 6033 Builtins::kCompileOptimizedConcurrent);
6039 } 6034 }
(...skipping 1591 matching lines...) Expand 10 before | Expand all | Expand 10 after
7631 #undef READ_SHORT_FIELD 7626 #undef READ_SHORT_FIELD
7632 #undef WRITE_SHORT_FIELD 7627 #undef WRITE_SHORT_FIELD
7633 #undef READ_BYTE_FIELD 7628 #undef READ_BYTE_FIELD
7634 #undef WRITE_BYTE_FIELD 7629 #undef WRITE_BYTE_FIELD
7635 #undef NOBARRIER_READ_BYTE_FIELD 7630 #undef NOBARRIER_READ_BYTE_FIELD
7636 #undef NOBARRIER_WRITE_BYTE_FIELD 7631 #undef NOBARRIER_WRITE_BYTE_FIELD
7637 7632
7638 } } // namespace v8::internal 7633 } } // namespace v8::internal
7639 7634
7640 #endif // V8_OBJECTS_INL_H_ 7635 #endif // V8_OBJECTS_INL_H_
OLDNEW
« no previous file with comments | « src/objects.cc ('k') | src/runtime-profiler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698