|
|
Created:
5 years, 7 months ago by payal.pandey Modified:
5 years, 7 months ago Reviewers:
eroman CC:
chromium-reviews, cbentzel+watch_chromium.org, Evan Stade Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionConverted bare pointers to scoped_ptr in net/base
BUG=479898
Committed: https://crrev.com/f74037a50b587582ad70fa5c2ffa1ae2bf2fc8f3
Cr-Commit-Position: refs/heads/master@{#331269}
Patch Set 1 #
Total comments: 1
Patch Set 2 : Incorporated review comments #
Total comments: 1
Patch Set 3 : Fixed the flaky tests. #Patch Set 4 : Fixed #Messages
Total messages: 19 (9 generated)
payal.pandey@samsung.com changed reviewers: + eroman@chromium.org
Please take a look, thanks.
lgtm https://codereview.chromium.org/1146413002/diff/1/net/base/sdch_net_log_param... File net/base/sdch_net_log_params.cc (right): https://codereview.chromium.org/1146413002/diff/1/net/base/sdch_net_log_param... net/base/sdch_net_log_params.cc:15: scoped_ptr<base::DictionaryValue> dict(new base::DictionaryValue()); The changes in this file are also covered by Evan' change: https://codereview.chromium.org/1149763005/diff/20001/net/base/sdch_net_log_p... Shouldn't really cause a problem whether you keep or remove them from this changelist.
The CQ bit was checked by payal.pandey@samsung.com
The patchset sent to the CQ was uploaded after l-g-t-m from eroman@chromium.org Link to the patchset: https://codereview.chromium.org/1146413002/#ps20001 (title: "Incorporated review comments")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1146413002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
https://codereview.chromium.org/1146413002/diff/20001/net/base/sdch_manager.cc File net/base/sdch_manager.cc (right): https://codereview.chromium.org/1146413002/diff/20001/net/base/sdch_manager.c... net/base/sdch_manager.cc:517: entry_list.reset(); The bug is here
The CQ bit was checked by payal.pandey@samsung.com
The patchset sent to the CQ was uploaded after l-g-t-m from eroman@chromium.org Link to the patchset: https://codereview.chromium.org/1146413002/#ps40001 (title: "Fixed the flaky tests.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1146413002/40001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_gn_dbg on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by payal.pandey@samsung.com
The patchset sent to the CQ was uploaded after l-g-t-m from eroman@chromium.org Link to the patchset: https://codereview.chromium.org/1146413002/#ps60001 (title: "Fixed")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1146413002/60001
Message was sent while issue was closed.
Committed patchset #4 (id:60001)
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/f74037a50b587582ad70fa5c2ffa1ae2bf2fc8f3 Cr-Commit-Position: refs/heads/master@{#331269} |