Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1121)

Issue 1146413002: Converted bare pointers to scoped_ptr in net/base (Closed)

Created:
5 years, 7 months ago by payal.pandey
Modified:
5 years, 7 months ago
Reviewers:
eroman
CC:
chromium-reviews, cbentzel+watch_chromium.org, Evan Stade
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Converted bare pointers to scoped_ptr in net/base BUG=479898 Committed: https://crrev.com/f74037a50b587582ad70fa5c2ffa1ae2bf2fc8f3 Cr-Commit-Position: refs/heads/master@{#331269}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Incorporated review comments #

Total comments: 1

Patch Set 3 : Fixed the flaky tests. #

Patch Set 4 : Fixed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -12 lines) Patch
M net/base/sdch_manager.cc View 1 2 3 1 chunk +12 lines, -12 lines 0 comments Download

Messages

Total messages: 19 (9 generated)
payal.pandey
Please take a look, thanks.
5 years, 7 months ago (2015-05-21 13:57:57 UTC) #2
eroman
lgtm https://codereview.chromium.org/1146413002/diff/1/net/base/sdch_net_log_params.cc File net/base/sdch_net_log_params.cc (right): https://codereview.chromium.org/1146413002/diff/1/net/base/sdch_net_log_params.cc#newcode15 net/base/sdch_net_log_params.cc:15: scoped_ptr<base::DictionaryValue> dict(new base::DictionaryValue()); The changes in this file ...
5 years, 7 months ago (2015-05-21 14:43:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1146413002/20001
5 years, 7 months ago (2015-05-22 05:58:32 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/60052)
5 years, 7 months ago (2015-05-22 07:17:26 UTC) #8
eroman
https://codereview.chromium.org/1146413002/diff/20001/net/base/sdch_manager.cc File net/base/sdch_manager.cc (right): https://codereview.chromium.org/1146413002/diff/20001/net/base/sdch_manager.cc#newcode517 net/base/sdch_manager.cc:517: entry_list.reset(); The bug is here
5 years, 7 months ago (2015-05-22 15:38:28 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1146413002/40001
5 years, 7 months ago (2015-05-25 06:29:51 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_chromeos_rel/builds/40637) linux_chromium_gn_dbg on tryserver.chromium.linux (JOB_FAILED, ...
5 years, 7 months ago (2015-05-25 06:40:09 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1146413002/60001
5 years, 7 months ago (2015-05-25 06:43:15 UTC) #17
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 7 months ago (2015-05-25 08:11:56 UTC) #18
commit-bot: I haz the power
5 years, 7 months ago (2015-05-25 08:12:47 UTC) #19
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/f74037a50b587582ad70fa5c2ffa1ae2bf2fc8f3
Cr-Commit-Position: refs/heads/master@{#331269}

Powered by Google App Engine
This is Rietveld 408576698