Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issue 1146403010: PPC: [es6] Super call in arrows and eval (Closed)

Created:
5 years, 6 months ago by MTBrandyberry
Modified:
5 years, 6 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: [es6] Super call in arrows and eval Port 4b8051a02ae9f765b7d803fc7986301abde36007 Original commit message: This splits the SuperReference AST node into SuperPropertyReference and SuperCallReference. The super call reference node consists of three unresolved vars to this, new.target and this_function. These gets declared when the right function is entered and if it is in use. The variables gets assigned in FullCodeGenerator::Generate. This is a revert of the revert 88b1c9170a0293cbcc8bdaf57fbe12744b48d7e8 R=arv@chromium.org, dstence@us.ibm.com, michael_dawson@ca.ibm.com BUG= Committed: https://crrev.com/172ecd610918ee48f317e3c5887cf63d6ac653a3 Cr-Commit-Position: refs/heads/master@{#28791}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -41 lines) Patch
M src/ppc/full-codegen-ppc.cc View 19 chunks +66 lines, -41 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
MTBrandyberry
5 years, 6 months ago (2015-06-03 01:45:21 UTC) #1
dstence
lgtm
5 years, 6 months ago (2015-06-03 15:28:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1146403010/1
5 years, 6 months ago (2015-06-03 15:28:32 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-03 15:50:49 UTC) #5
commit-bot: I haz the power
5 years, 6 months ago (2015-06-03 15:50:59 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/172ecd610918ee48f317e3c5887cf63d6ac653a3
Cr-Commit-Position: refs/heads/master@{#28791}

Powered by Google App Engine
This is Rietveld 408576698