Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(769)

Issue 1146403009: Revert of Bring RFH/RVH unit tests closer to reality of how RF/RV are initialized (Closed)

Created:
5 years, 6 months ago by Nico
Modified:
5 years, 6 months ago
Reviewers:
ncarter (slow), bengr, nasko, sky
CC:
chromium-reviews, jam, nasko+codewatch_chromium.org, creis+watch_chromium.org, darin-cc_chromium.org, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Bring RFH/RVH unit tests closer to reality of how RF/RV are initialized (patchset #8 id:130001 of https://codereview.chromium.org/1151973005/) Reason for revert: Speculative, might have caused http://crbug.com/493584 (RlzLibTests failing in unit_tests in official builds) Original issue's description: > Bring RFH/RVH unit tests closer to reality of how RF/RV are initialized > > BUG=357747 > TEST=all unit tests continue passing > TBR=sky@chromium.org > > Committed: https://crrev.com/c88002d1c4dc328fbe519dac9a88ba00396836b4 > Cr-Commit-Position: refs/heads/master@{#331894} TBR=nick@chromium.org,bengr@chromium.org,sky@chromium.org,nasko@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=357747 Committed: https://crrev.com/0cbda411462a1adef17e550c2db22c57dedae810 Cr-Commit-Position: refs/heads/master@{#332117}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -44 lines) Patch
M chrome/browser/safe_browsing/safe_browsing_blocking_page_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/data_reduction_proxy/content/browser/data_reduction_proxy_debug_blocking_page_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/frame_host/frame_tree_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/frame_host/navigation_controller_impl_unittest.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M content/browser/frame_host/render_frame_host_impl.cc View 1 chunk +6 lines, -7 lines 0 comments Download
M content/browser/web_contents/aura/overscroll_navigation_overlay_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/web_contents/web_contents_impl_unittest.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M content/test/test_render_frame_host.h View 1 chunk +0 lines, -5 lines 0 comments Download
M content/test/test_render_frame_host.cc View 5 chunks +12 lines, -11 lines 0 comments Download
M content/test/test_render_view_host.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M content/test/test_web_contents.cc View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Nico
Created Revert of Bring RFH/RVH unit tests closer to reality of how RF/RV are initialized
5 years, 6 months ago (2015-05-30 07:03:10 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1146403009/1
5 years, 6 months ago (2015-05-30 07:03:13 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-05-30 07:03:41 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/0cbda411462a1adef17e550c2db22c57dedae810 Cr-Commit-Position: refs/heads/master@{#332117}
5 years, 6 months ago (2015-05-30 07:04:37 UTC) #4
Nico
5 years, 6 months ago (2015-05-30 16:45:20 UTC) #5
Message was sent while issue was closed.
On 2015/05/30 07:04:37, commit-bot: I haz the power wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/0cbda411462a1adef17e550c2db22c57dedae810
> Cr-Commit-Position: refs/heads/master@{#332117}

Looks like this helped

Powered by Google App Engine
This is Rietveld 408576698