Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 1146403008: [turbofan] Use Start as sentinel for frame states. (Closed)

Created:
5 years, 7 months ago by Benedikt Meurer
Modified:
5 years, 7 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Use Start as sentinel for frame states. This simplifies inlining, in that we only need to update uses of Start and inputs of End instead of walking the whole inlinee to update all outer frame states. R=mstarzinger@chromium.org Committed: https://crrev.com/7483dbd5fcb9b8a5a4d0b44c9a52eca1b716166f Cr-Commit-Position: refs/heads/master@{#28649}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -21 lines) Patch
M src/compiler/ast-graph-builder.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/js-graph.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/js-inlining.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/js-inlining.cc View 4 chunks +7 lines, -16 lines 0 comments Download
M src/compiler/verifier.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M test/cctest/compiler/test-run-inlining.cc View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Benedikt Meurer
5 years, 7 months ago (2015-05-27 10:38:51 UTC) #1
Benedikt Meurer
Hey Michi, Jaro, Inlining cleanup. Please take a look. Thanks, Benedikt
5 years, 7 months ago (2015-05-27 10:39:27 UTC) #3
Jarin
lgtm
5 years, 7 months ago (2015-05-27 10:43:12 UTC) #4
Michael Starzinger
LGTM.
5 years, 7 months ago (2015-05-27 11:00:29 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1146403008/1
5 years, 7 months ago (2015-05-27 11:00:44 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-27 11:01:56 UTC) #8
commit-bot: I haz the power
5 years, 7 months ago (2015-05-27 11:02:10 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7483dbd5fcb9b8a5a4d0b44c9a52eca1b716166f
Cr-Commit-Position: refs/heads/master@{#28649}

Powered by Google App Engine
This is Rietveld 408576698