chrome/browser/content_settings/permission_context_base.cc - Issue 1146403004: MidiPermissionContext::GetPermission() returns BLOCK for insecure origins.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/content_settings/permission_context_base.cc

Issue 1146403004: MidiPermissionContext::GetPermission() returns BLOCK for insecure origins. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/content_settings/permission_context_base_unittest.cc » ('j') | chrome/browser/media/midi_permission_context_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/content_settings/permission_context_base.cc

diff --git a/chrome/browser/content_settings/permission_context_base.cc b/chrome/browser/content_settings/permission_context_base.cc

index 9cd5d1260c7e753a037079ad04fb181c9265c406..d4d5322e4649b89fc745f74b43849acde32dcae8 100644

--- a/chrome/browser/content_settings/permission_context_base.cc

+++ b/chrome/browser/content_settings/permission_context_base.cc

@@ -17,7 +17,6 @@

#include "components/content_settings/core/common/permission_request_id.h"

#include "content/public/browser/browser_thread.h"

#include "content/public/browser/web_contents.h"

-#include "content/public/common/origin_util.h"

PermissionContextBase::PermissionContextBase(

Profile* profile,

@@ -105,14 +104,6 @@ void PermissionContextBase::DecidePermission(

return;

}

- // The Web MIDI SYSEX API is only available to secure origins.

- if (permission_type_ == CONTENT_SETTINGS_TYPE_MIDI_SYSEX &&

- !content::IsOriginSecure(requesting_origin)) {

- NotifyPermissionSet(id, requesting_origin, embedding_origin, callback,

- false /* persist */, CONTENT_SETTING_BLOCK);

- return;

- }

ContentSetting content_setting =

profile_->GetHostContentSettingsMap()

->GetContentSettingAndMaybeUpdateLastUsage(