net/url_request/url_fetcher_impl.h - Issue 11464028: Introduce ERR_NETWORK_CHANGED and allow URLFetcher to automatically retry on that error.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/url_request/url_fetcher_impl.h

Issue 11464028: Introduce ERR_NETWORK_CHANGED and allow URLFetcher to automatically retry on that error. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebased, post first try if online, more tests Created 8 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/url_request/url_fetcher_impl.h

diff --git a/net/url_request/url_fetcher_impl.h b/net/url_request/url_fetcher_impl.h

index eb7e315ccaca85a57669ef53ef179bb128c0b7a8..9b0c1decd13aac79d2fd6e6c97e97a5ee779a4c4 100644

--- a/net/url_request/url_fetcher_impl.h

+++ b/net/url_request/url_fetcher_impl.h

@@ -58,9 +58,10 @@ class NET_EXPORT_PRIVATE URLFetcherImpl : public URLFetcher {

const CreateDataCallback& create_data_callback) OVERRIDE;

virtual void SetStopOnRedirect(bool stop_on_redirect) OVERRIDE;

virtual void SetAutomaticallyRetryOn5xx(bool retry) OVERRIDE;

- virtual void SetMaxRetries(int max_retries) OVERRIDE;

- virtual int GetMaxRetries() const OVERRIDE;

+ virtual void SetMaxRetriesOn5xx(int max_retries) OVERRIDE;

+ virtual int GetMaxRetriesOn5xx() const OVERRIDE;

virtual base::TimeDelta GetBackoffDelay() const OVERRIDE;

+ virtual void SetAutomaticallyRetryOnNetworkChanges(int max_retries) OVERRIDE;

virtual void SaveResponseToFileAtPath(

const FilePath& file_path,

scoped_refptr<base::TaskRunner> file_task_runner) OVERRIDE;

« net/url_request/url_fetcher_core.cc ('K') | « net/url_request/url_fetcher_core.cc ('k') | net/url_request/url_fetcher_impl.cc » ('j') | net/url_request/url_fetcher_impl_unittest.cc » ('J')