Introduce ERR_NETWORK_CHANGED and allow URLFetcher to automatically retry on that error.

net/url_request/test_url_fetcher_factory.h

Index: net/url_request/test_url_fetcher_factory.h
diff --git a/net/url_request/test_url_fetcher_factory.h b/net/url_request/test_url_fetcher_factory.h
index b1e9e78269001e4673b9661c89c18c00f6e0c621..27f2f7a90b7adbd73398444284cb61a4ace095fa 100644
--- a/net/url_request/test_url_fetcher_factory.h
+++ b/net/url_request/test_url_fetcher_factory.h
@@ -106,9 +106,10 @@ class TestURLFetcher : public URLFetcher {
       const CreateDataCallback& create_data_callback) OVERRIDE;
   virtual void SetStopOnRedirect(bool stop_on_redirect) OVERRIDE;
   virtual void SetAutomaticallyRetryOn5xx(bool retry) OVERRIDE;
-  virtual void SetMaxRetries(int max_retries) OVERRIDE;
-  virtual int GetMaxRetries() const OVERRIDE;
+  virtual void SetMaxRetriesOn5xx(int max_retries) OVERRIDE;

[szym, 2012/12/10 18:36:31]

It seems the only non-test place that cares about this is CloudPrintURLFetcher
and it does not use the URLFetcher's retry logic, so I'm not sure there's the
need to separate the maximums for 5xx retries and NetworkChange retries.

[Joao da Silva, 2012/12/11 13:36:43]

grep finds a couple more users:

chrome/browser/chrome_to_mobile_service.cc
chrome/browser/google/google_url_tracker.cc
chrome/browser/metrics/variations/variations_service.cc
chrome/browser/translate/translate_manager.cc
chrome/service/cloud_print/cloud_print_url_fetcher.cc
google_apis/gaia/gaia_oauth_client.cc

It's not clear to me if you're suggesting to merge the maximums for the
TestURLFetcher or for the URLFetcherCore. I think they can be merged in the
core; can you clarify this?

+  virtual int GetMaxRetriesOn5xx() const OVERRIDE;
   virtual base::TimeDelta GetBackoffDelay() const OVERRIDE;
+  virtual void SetAutomaticallyRetryOnNetworkChanges(int max_retries) OVERRIDE;
   virtual void SaveResponseToFileAtPath(
       const FilePath& file_path,
       scoped_refptr<base::TaskRunner> file_task_runner) OVERRIDE;