net/socket/client_socket_pool_base.h - Issue 11464028: Introduce ERR_NETWORK_CHANGED and allow URLFetcher to automatically retry on that error.

Unified Diff: net/socket/client_socket_pool_base.h

Issue 11464028: Introduce ERR_NETWORK_CHANGED and allow URLFetcher to automatically retry on that error. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebased, post first try if online, more tests Created 8 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/socket/client_socket_pool_base.h

diff --git a/net/socket/client_socket_pool_base.h b/net/socket/client_socket_pool_base.h

index e35ab29fca11f767943d2ff2a676ac216e3921b4..3026570ab09bbe17ed7ee546620c8e7845686cbf 100644

--- a/net/socket/client_socket_pool_base.h

+++ b/net/socket/client_socket_pool_base.h

@@ -243,7 +243,7 @@ class NET_EXPORT_PRIVATE ClientSocketPoolBaseHelper

int id);

// See ClientSocketPool::Flush for documentation on this function.

- void Flush();

+ void Flush(int error);

szym 2012/12/10 18:36:31 The documentation is now inconsistent, since Clien

Joao da Silva 2012/12/11 13:36:43 Documented the |error| arg.

// See ClientSocketPool::IsStalled for documentation on this function.

bool IsStalled() const;

@@ -505,9 +505,9 @@ class NET_EXPORT_PRIVATE ClientSocketPoolBaseHelper

// groups if they are no longer needed.

void CancelAllConnectJobs();

- // Iterates through |group_map_|, posting ERR_ABORTED callbacks for all

+ // Iterates through |group_map_|, posting |error| callbacks for all

// requests, and then deleting groups if they are no longer needed.

- void AbortAllRequests();

+ void AbortAllRequests(int error);

// Returns true if we can't create any more sockets due to the total limit.

bool ReachedMaxSocketsLimit() const;

@@ -708,7 +708,7 @@ class ClientSocketPoolBase {

return helper_.ReleaseSocket(group_name, socket, id);

}

- void Flush() { helper_.Flush(); }

+ void Flush() { helper_.Flush(ERR_ABORTED); }

szym 2012/12/10 18:36:31 We don't flush sockets on user request (aside from

Joao da Silva 2012/12/11 13:36:43 Changed to ERR_NETWORK_CHANGED. @Will: does this

bool IsStalled() const { return helper_.IsStalled(); }

« net/base/mock_host_resolver.h ('K') | « net/http/http_pipelined_connection_impl.cc ('k') | net/socket/client_socket_pool_base.cc » ('j') | net/spdy/spdy_session_pool.cc » ('J')