Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(374)

Unified Diff: dart/sdk/lib/_internal/compiler/implementation/compiler.dart

Issue 11464026: Diagnose illegal lvalues better. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | dart/sdk/lib/_internal/compiler/implementation/scanner/listener.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dart/sdk/lib/_internal/compiler/implementation/compiler.dart
diff --git a/dart/sdk/lib/_internal/compiler/implementation/compiler.dart b/dart/sdk/lib/_internal/compiler/implementation/compiler.dart
index a8ed28b8e66e16eddc4ac20f6cbdf38d81817e66..23f6302800cc4c169ae8f4eeff986bc54de26366 100644
--- a/dart/sdk/lib/_internal/compiler/implementation/compiler.dart
+++ b/dart/sdk/lib/_internal/compiler/implementation/compiler.dart
@@ -162,6 +162,7 @@ abstract class Compiler implements DiagnosticListener {
if (!hasCrashed) {
SourceSpan span = spanFromSpannable(ex.node);
reportDiagnostic(span, ex.message, api.Diagnostic.ERROR);
+ pleaseReportCrash();
ngeoffray 2012/12/09 21:06:56 You're just too nice Peter :-)
}
hasCrashed = true;
throw;
@@ -304,6 +305,10 @@ abstract class Compiler implements DiagnosticListener {
reportDiagnostic(spanFromElement(element),
MessageKind.COMPILER_CRASHED.error().toString(),
api.Diagnostic.CRASH);
+ pleaseReportCrash();
+ }
+
+ void pleaseReportCrash() {
print(MessageKind.PLEASE_REPORT_THE_CRASH.message([BUILD_ID]));
}
« no previous file with comments | « no previous file | dart/sdk/lib/_internal/compiler/implementation/scanner/listener.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698