Separate image processing logic from presentation logic.

ui/surface/accelerated_surface_transformer_win_unittest.cc

Index: ui/surface/accelerated_surface_transformer_win_unittest.cc
diff --git a/ui/surface/accelerated_surface_transformer_win_unittest.cc b/ui/surface/accelerated_surface_transformer_win_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..5402c424e545fa946ffe5da34dafa686c653b6e0
--- /dev/null
+++ b/ui/surface/accelerated_surface_transformer_win_unittest.cc
@@ -0,0 +1,526 @@
+// Copyright (c) 2010 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include <d3d9.h>
+#include <random>
+
+#include "base/basictypes.h"
+#include "base/hash.h"
+#include "base/scoped_native_library.h"
+#include "base/stringprintf.h"
+#include "base/win/scoped_comptr.h"
+#include "base/win/windows_version.h"
+#include "testing/gtest/include/gtest/gtest-param-test.h"
+#include "testing/gtest/include/gtest/gtest.h"
+#include "ui/gfx/rect.h"
+#include "ui/surface/accelerated_surface_transformer_win.h"
+#include "ui/surface/accelerated_surface_win.h"
+#include "ui/surface/d3d9_utils_win.h"
+
+namespace d3d_utils = ui_surface_d3d9_utils;
+
+using base::win::ScopedComPtr;
+using std::uniform_int_distribution;
+
+// Provides a reference rasterizer (all rendering done by software emulation)
+// Direct3D device, for use by unit tests.
+//
+// This class is parameterized so that it runs only on Vista+. See
+// WindowsVersionIfVistaOrBetter() for details on this works.
+class AcceleratedSurfaceTransformerTest : public testing::TestWithParam<int> {
+ public:
+  AcceleratedSurfaceTransformerTest() {};
+
+  IDirect3DDevice9Ex* device() { return device_.get(); }
+
+  virtual void SetUp() {
+    if (!d3d_module_.is_valid()) {
+      if (!d3d_utils::LoadD3D9(&d3d_module_)) {
+        GTEST_FAIL() << "Could not load d3d9.dll";
+        return;
+      }
+    }
+    if (!d3d_utils::CreateDevice(d3d_module_,
+                                 D3DDEVTYPE_HAL,
+                                 D3DPRESENT_INTERVAL_IMMEDIATE,
+                                 device_.Receive())) {
+      GTEST_FAIL() << "Could not create Direct3D device.";
+      return;
+    }
+
+    SeedRandom("default");
+  }
+
+  virtual void TearDown() {
+    device_ = NULL;
+  }
+
+  // Gets a human-readable identifier of the graphics hardware being used,
+  // intended for use inside of SCOPED_TRACE().
+  std::string GetAdapterInfo() {
+    ScopedComPtr<IDirect3D9> d3d;
+    EXPECT_HRESULT_SUCCEEDED(device()->GetDirect3D(d3d.Receive()));
+    D3DADAPTER_IDENTIFIER9 info;
+    EXPECT_HRESULT_SUCCEEDED(d3d->GetAdapterIdentifier(0, 0, &info));
+    return StringPrintf("Running on graphics hardware: %s", info.Description);
+  }
+
+  void SeedRandom(const char* seed) {
+    rng_.seed(base::Hash(seed));
+    random_dword_.reset();
+  }
+
+  // Driver workaround: on an Intel GPU (Mobile Intel 965 Express), it seems
+  // necessary to flush between drawing and locking, for the synchronization
+  // to behave properly.
+  void BeforeLockWorkaround() {
+    EXPECT_HRESULT_SUCCEEDED(
+        device()->Present(0, 0, 0, 0));

[apatrick_chromium, 2013/01/02 20:45:58]

Eek! Have you considered using a reference device instead of HAL?

[ncarter (slow), 2013/01/02 23:35:21]

Using a reference device was my original intent when I wrote these tests, but
the reference device doesn't support our usage of StretchRect (it fails if you
ask for LINEAR filtering). So here we are.

I was really caught off guard by the behavior where draw/lock didn't
synchronize. I did not try using an event query to flush, but I think it might
work too.

My immediate goal is to get these tests running on the GPU bots and see what
other gotchas might be lurking.

+  }
+
+  // Locks and fills a surface with a checkerboard pattern where the colors
+  // are random but the total image pattern is horizontally and vertically
+  // symmetric.
+  void FillSymmetricRandomCheckerboard(
+      IDirect3DSurface9* lockable_surface,
+      const gfx::Size& size,
+      int checker_square_size) {
+
+    D3DLOCKED_RECT locked_rect;
+    ASSERT_HRESULT_SUCCEEDED(
+        lockable_surface->LockRect(&locked_rect, NULL, D3DLOCK_DISCARD));
+    DWORD* surface = reinterpret_cast<DWORD*>(locked_rect.pBits);
+    ASSERT_EQ(0, locked_rect.Pitch % sizeof(DWORD));
+    int pitch = locked_rect.Pitch / sizeof(DWORD);
+
+    for (int y = 0; y <= size.height() / 2; y += checker_square_size) {
+      for (int x = 0; x <= size.width() / 2; x += checker_square_size) {
+        DWORD color = RandomColor();
+        int y_limit = std::min(size.height() / 2, y + checker_square_size - 1);
+        int x_limit = std::min(size.width() / 2, x + checker_square_size - 1);
+        for (int y_lo = y; y_lo <= y_limit; y_lo++) {
+          for (int x_lo = x; x_lo <= x_limit; x_lo++) {
+            int y_hi = size.height() - 1 - y_lo;
+            int x_hi = size.width() - 1 - x_lo;
+            surface[x_lo + y_lo*pitch] = color;
+            surface[x_lo + y_hi*pitch] = color;
+            surface[x_hi + y_lo*pitch] = color;
+            surface[x_hi + y_hi*pitch] = color;
+          }
+        }
+      }
+    }
+
+    lockable_surface->UnlockRect();
+  }
+
+  void FillRandomCheckerboard(
+      IDirect3DSurface9* lockable_surface,
+      const gfx::Size& size,
+      int checker_square_size) {
+
+    D3DLOCKED_RECT locked_rect;
+    ASSERT_HRESULT_SUCCEEDED(
+        lockable_surface->LockRect(&locked_rect, NULL, D3DLOCK_DISCARD));
+    DWORD* surface = reinterpret_cast<DWORD*>(locked_rect.pBits);
+    ASSERT_EQ(0, locked_rect.Pitch % sizeof(DWORD));
+    int pitch = locked_rect.Pitch / sizeof(DWORD);
+
+    for (int y = 0; y <= size.height(); y += checker_square_size) {
+      for (int x = 0; x <= size.width(); x += checker_square_size) {
+        DWORD color = RandomColor();
+        int y_limit = std::min(size.height(), y + checker_square_size);
+        int x_limit = std::min(size.width(), x + checker_square_size);
+        for (int square_y = y; square_y < y_limit; square_y++) {
+          for (int square_x = x; square_x < x_limit; square_x++) {
+            surface[square_x + square_y*pitch] = color;
+          }
+        }
+      }
+    }
+
+    lockable_surface->UnlockRect();
+  }
+
+  // Approximate color-equality check. Allows for some rounding error.
+  bool AssertSameColor(DWORD color_a, DWORD color_b) {
+    if (color_a == color_b)
+      return true;
+    uint8* a = reinterpret_cast<uint8*>(&color_a);
+    uint8* b = reinterpret_cast<uint8*>(&color_b);
+    int max_error = 0;
+    for (int i = 0; i < 4; i++)
+      max_error = std::max(max_error,
+          std::abs(static_cast<int>(a[i]) - b[i]));
+
+    if (max_error <= kAbsoluteColorErrorTolerance)
+      return true;
+
+    std::string expected_color =
+        StringPrintf("%3d, %3d, %3d, %3d", a[0], a[1], a[2], a[3]);
+    std::string actual_color =
+        StringPrintf("%3d, %3d, %3d, %3d", b[0], b[1], b[2], b[3]);
+    EXPECT_EQ(expected_color, actual_color)
+        << "Componentwise color difference was "
+        << max_error << "; max allowed is " << kAbsoluteColorErrorTolerance;
+
+    return false;
+  }
+
+  // Asserts that an image is symmetric with respect to itself: both
+  // horizontally and vertically, within the tolerance of AssertSameColor.
+  void AssertSymmetry(IDirect3DSurface9* lockable_surface,
+                      const gfx::Size& size) {
+    BeforeLockWorkaround();
+
+    D3DLOCKED_RECT locked_rect;
+    ASSERT_HRESULT_SUCCEEDED(
+        lockable_surface->LockRect(&locked_rect, NULL, D3DLOCK_READONLY));
+    ASSERT_EQ(0, locked_rect.Pitch % sizeof(DWORD));
+    int pitch = locked_rect.Pitch / sizeof(DWORD);
+    DWORD* surface = reinterpret_cast<DWORD*>(locked_rect.pBits);
+    for (int y_lo = 0; y_lo < size.height() / 2; y_lo++) {
+      int y_hi = size.height() - 1 - y_lo;
+      for (int x_lo = 0; x_lo < size.width() / 2; x_lo++) {
+        int x_hi = size.width() - 1 - x_lo;
+        if (!AssertSameColor(surface[x_lo + y_lo*pitch],
+                             surface[x_hi + y_lo*pitch])) {
+          lockable_surface->UnlockRect();
+          GTEST_FAIL() << "Pixels (" << x_lo << ", " << y_lo << ") vs. "
+                       << "(" << x_hi << ", " << y_lo << ")";
+        }
+        if (!AssertSameColor(surface[x_hi + y_lo*pitch],
+                             surface[x_hi + y_hi*pitch])) {
+          lockable_surface->UnlockRect();
+          GTEST_FAIL() << "Pixels (" << x_hi << ", " << y_lo << ") vs. "
+                       << "(" << x_hi << ", " << y_hi << ")";
+        }
+        if (!AssertSameColor(surface[x_hi + y_hi*pitch],
+                             surface[x_lo + y_hi*pitch])) {
+          lockable_surface->UnlockRect();
+          GTEST_FAIL() << "Pixels (" << x_hi << ", " << y_hi << ") vs. "
+                       << "(" << x_lo << ", " << y_hi << ")";
+        }
+      }
+    }
+    lockable_surface->UnlockRect();
+  }
+
+  // Asserts that the actual image is a bit-identical, vertically mirrored
+  // copy of the expected image.
+  void AssertIsInvertedCopy(const gfx::Size& size,
+                            IDirect3DSurface9* expected,
+                            IDirect3DSurface9* actual) {
+    BeforeLockWorkaround();
+
+    D3DLOCKED_RECT locked_expected, locked_actual;
+    ASSERT_HRESULT_SUCCEEDED(
+        expected->LockRect(&locked_expected, NULL, D3DLOCK_READONLY));
+    ASSERT_HRESULT_SUCCEEDED(
+        actual->LockRect(&locked_actual, NULL, D3DLOCK_READONLY));
+    ASSERT_EQ(0, locked_expected.Pitch % sizeof(DWORD));
+    int pitch = locked_expected.Pitch / sizeof(DWORD);
+    DWORD* expected_image = reinterpret_cast<DWORD*>(locked_expected.pBits);
+    DWORD* actual_image = reinterpret_cast<DWORD*>(locked_actual.pBits);
+    for (int y = 0; y < size.height(); y++) {
+      int y_actual = size.height() - 1 - y;
+      for (int x = 0; x < size.width(); ++x)
+        if (!AssertSameColor(expected_image[y*pitch + x],
+                             actual_image[y_actual*pitch + x])) {
+          expected->UnlockRect();
+          actual->UnlockRect();
+          GTEST_FAIL() << "Pixels (" << x << ", " << y << ") vs. "
+                       << "(" << x << ", " << y_actual << ")";
+        }
+    }
+    expected->UnlockRect();
+    actual->UnlockRect();
+  }
+
+ protected:
+  static const int kAbsoluteColorErrorTolerance = 5;
+
+  DWORD RandomColor() {
+    return random_dword_(rng_);
+  }
+
+  void DoResizeBilinearTest(AcceleratedSurfaceTransformer* gpu_ops,
+                            const gfx::Size& src_size,
+                            const gfx::Size& dst_size,
+                            int checkerboard_size) {
+
+    SCOPED_TRACE(
+        StringPrintf("Resizing %dx%d -> %dx%d at checkerboard size of %d",
+                     src_size.width(), src_size.height(),
+                     dst_size.width(), dst_size.height(),
+                     checkerboard_size));
+
+    base::win::ScopedComPtr<IDirect3DSurface9> src, dst;
+    ASSERT_TRUE(d3d_utils::CreateTemporaryLockableSurface(
+        device(), src_size, src.Receive()))
+            << "Could not create src render target";
+    ASSERT_TRUE(d3d_utils::CreateTemporaryLockableSurface(
+        device(), dst_size, dst.Receive()))
+            << "Could not create dst render target";
+
+    FillSymmetricRandomCheckerboard(src, src_size, checkerboard_size);
+
+    ASSERT_TRUE(gpu_ops->ResizeBilinear(src, gfx::Rect(src_size), dst));
+
+    AssertSymmetry(dst, dst_size);
+  }
+
+  void DoCopyInvertedTest(AcceleratedSurfaceTransformer* gpu_ops,
+                          const gfx::Size& size) {
+
+    SCOPED_TRACE(
+        StringPrintf("CopyInverted @ %dx%d", size.width(), size.height()));
+
+    base::win::ScopedComPtr<IDirect3DSurface9> checkerboard, src, dst;
+    base::win::ScopedComPtr<IDirect3DTexture9> src_texture;
+    ASSERT_TRUE(d3d_utils::CreateTemporaryLockableSurface(device(), size,
+        checkerboard.Receive())) << "Could not create src render target";;
+    ASSERT_TRUE(d3d_utils::CreateTemporaryRenderTargetTexture(device(), size,
+        src_texture.Receive(), src.Receive()))
+            << "Could not create src texture.";
+    ASSERT_TRUE(d3d_utils::CreateTemporaryLockableSurface(device(), size,
+        dst.Receive())) << "Could not create dst render target.";
+
+    FillRandomCheckerboard(checkerboard, size, 1);
+    ASSERT_HRESULT_SUCCEEDED(
+        device()->StretchRect(checkerboard, NULL, src, NULL, D3DTEXF_NONE));
+    ASSERT_TRUE(gpu_ops->CopyInverted(src_texture, dst, size));
+    AssertIsInvertedCopy(size, checkerboard, dst);
+  }
+
+  uniform_int_distribution<DWORD> random_dword_;
+  std::mt19937 rng_;
+  base::ScopedNativeLibrary d3d_module_;
+  base::win::ScopedComPtr<IDirect3DDevice9Ex> device_;
+};
+
+// Fails on some bots because Direct3D isn't allowed.
+TEST_P(AcceleratedSurfaceTransformerTest, FAILS_Init) {
+  SCOPED_TRACE(GetAdapterInfo());
+  AcceleratedSurfaceTransformer gpu_ops;
+  ASSERT_TRUE(gpu_ops.Init(device()));
+};
+
+// Fails on some bots because Direct3D isn't allowed.
+TEST_P(AcceleratedSurfaceTransformerTest, FAILS_TestConsistentRandom) {
+  // This behavior should be the same for every execution on every machine.
+  // Otherwise tests might be flaky and impossible to debug.
+  SeedRandom("AcceleratedSurfaceTransformerTest.TestConsistentRandom");
+  ASSERT_EQ(2922058934, RandomColor());
+
+  SeedRandom("AcceleratedSurfaceTransformerTest.TestConsistentRandom");
+  ASSERT_EQ(2922058934, RandomColor());
+  ASSERT_EQ(4050239976, RandomColor());
+
+  SeedRandom("DifferentSeed");
+  ASSERT_EQ(3904108833, RandomColor());
+}
+
+// Fails on some bots because Direct3D isn't allowed.
+TEST_P(AcceleratedSurfaceTransformerTest, FAILS_CopyInverted) {
+  // This behavior should be the same for every execution on every machine.
+  // Otherwise tests might be flaky and impossible to debug.
+  SCOPED_TRACE(GetAdapterInfo());
+  SeedRandom("CopyInverted");
+
+  AcceleratedSurfaceTransformer t;
+  ASSERT_TRUE(t.Init(device()));
+
+  uniform_int_distribution<int> size(1, 512);
+
+  for (int i = 0; i < 100; ++i) {
+    ASSERT_NO_FATAL_FAILURE(
+        DoCopyInvertedTest(&t, gfx::Size(size(rng_), size(rng_))))
+            << "At iteration " << i;
+  }
+}
+
+
+// Fails on some bots because Direct3D isn't allowed.
+// Fails on other bots because of ResizeBilinear symmetry failures.
+// Should pass, at least, on NVIDIA Quadro 600.
+TEST_P(AcceleratedSurfaceTransformerTest, FAILS_MixedOperations) {
+  SCOPED_TRACE(GetAdapterInfo());
+  SeedRandom("MixedOperations");
+
+  AcceleratedSurfaceTransformer t;
+  ASSERT_TRUE(t.Init(device()));
+
+  ASSERT_NO_FATAL_FAILURE(
+      DoResizeBilinearTest(&t, gfx::Size(256, 256), gfx::Size(255, 255), 1));
+  ASSERT_NO_FATAL_FAILURE(
+      DoResizeBilinearTest(&t, gfx::Size(256, 256), gfx::Size(255, 255), 2));
+  ASSERT_NO_FATAL_FAILURE(
+      DoCopyInvertedTest(&t, gfx::Size(20, 107)));
+  ASSERT_NO_FATAL_FAILURE(
+      DoResizeBilinearTest(&t, gfx::Size(256, 256), gfx::Size(255, 255), 5));
+  ASSERT_NO_FATAL_FAILURE(
+      DoResizeBilinearTest(&t, gfx::Size(256, 256), gfx::Size(64, 64), 5));
+  ASSERT_NO_FATAL_FAILURE(
+      DoResizeBilinearTest(&t, gfx::Size(255, 255), gfx::Size(3, 3), 1));
+  ASSERT_NO_FATAL_FAILURE(
+      DoCopyInvertedTest(&t, gfx::Size(1412, 124)));
+  ASSERT_NO_FATAL_FAILURE(
+      DoResizeBilinearTest(&t, gfx::Size(255, 255), gfx::Size(257, 257), 1));
+  ASSERT_NO_FATAL_FAILURE(
+      DoResizeBilinearTest(&t, gfx::Size(255, 255), gfx::Size(257, 257), 2));
+
+  ASSERT_NO_FATAL_FAILURE(
+      DoCopyInvertedTest(&t, gfx::Size(1512, 7)));
+  ASSERT_NO_FATAL_FAILURE(
+      DoResizeBilinearTest(&t, gfx::Size(255, 255), gfx::Size(257, 257), 5));
+  ASSERT_NO_FATAL_FAILURE(
+      DoResizeBilinearTest(&t, gfx::Size(150, 256), gfx::Size(126, 256), 8));
+  ASSERT_NO_FATAL_FAILURE(
+      DoCopyInvertedTest(&t, gfx::Size(1521, 3)));
+  ASSERT_NO_FATAL_FAILURE(
+      DoResizeBilinearTest(&t, gfx::Size(150, 256), gfx::Size(126, 256), 1));
+  ASSERT_NO_FATAL_FAILURE(
+      DoCopyInvertedTest(&t, gfx::Size(33, 712)));
+  ASSERT_NO_FATAL_FAILURE(
+      DoResizeBilinearTest(&t, gfx::Size(150, 256), gfx::Size(126, 8), 8));
+  ASSERT_NO_FATAL_FAILURE(
+      DoCopyInvertedTest(&t, gfx::Size(33, 2)));
+  ASSERT_NO_FATAL_FAILURE(
+      DoResizeBilinearTest(&t, gfx::Size(200, 256), gfx::Size(126, 8), 8));
+}
+
+// Tests ResizeBilinear with 16K wide/hight src and dst surfaces.
+//
+// Fails on some bots because Direct3D isn't allowed.
+// Fails on other bots because of texture allocation failures.
+// Should pass, at least, on NVIDIA Quadro 600.
+TEST_P(AcceleratedSurfaceTransformerTest, FAILS_LargeSurfaces) {
+  SCOPED_TRACE(GetAdapterInfo());
+  SeedRandom("LargeSurfaces");
+
+  AcceleratedSurfaceTransformer gpu_ops;
+  ASSERT_TRUE(gpu_ops.Init(device()));
+
+  D3DCAPS9 caps;
+  ASSERT_HRESULT_SUCCEEDED(
+      device()->GetDeviceCaps(&caps));
+
+  SCOPED_TRACE(StringPrintf("max texture size: %dx%d, max texture aspect: %d",
+      caps.MaxTextureWidth, caps.MaxTextureHeight, caps.MaxTextureAspectRatio));
+
+  const int w = caps.MaxTextureWidth;
+  const int h = caps.MaxTextureHeight;
+  const int lo = 256;
+
+  ASSERT_NO_FATAL_FAILURE(
+      DoResizeBilinearTest(&gpu_ops, gfx::Size(w, lo), gfx::Size(lo, lo), 1));
+  ASSERT_NO_FATAL_FAILURE(
+      DoResizeBilinearTest(&gpu_ops, gfx::Size(lo, h), gfx::Size(lo, lo), 1));
+  ASSERT_NO_FATAL_FAILURE(
+      DoResizeBilinearTest(&gpu_ops, gfx::Size(lo, lo), gfx::Size(w, lo), lo));
+  ASSERT_NO_FATAL_FAILURE(
+      DoResizeBilinearTest(&gpu_ops, gfx::Size(lo, lo), gfx::Size(lo, h), lo));
+  ASSERT_NO_FATAL_FAILURE(
+      DoCopyInvertedTest(&gpu_ops, gfx::Size(w, lo)));
+  ASSERT_NO_FATAL_FAILURE(
+      DoCopyInvertedTest(&gpu_ops, gfx::Size(lo, h)));
+}
+
+// Exercises ResizeBilinear with random minification cases where the
+// aspect ratio does not change.
+//
+// Fails on some bots because Direct3D isn't allowed.
+// Fails on other bots because of ResizeBilinear symmetry failures.
+// Should pass, at least, on NVIDIA Quadro 600.
+TEST_P(AcceleratedSurfaceTransformerTest, FAILS_MinifyUniform) {
+  SCOPED_TRACE(GetAdapterInfo());
+  SeedRandom("MinifyUniform");
+
+  AcceleratedSurfaceTransformer gpu_ops;
+  ASSERT_TRUE(gpu_ops.Init(device()));
+
+  int dims[] = { 21, 63, 64, 65, 99, 127, 128, 129, 192, 255, 256, 257};
+  int checkerboards[] = {1, 2, 3, 9};
+  uniform_int_distribution<int> dim(0, arraysize(dims) - 1);
+  uniform_int_distribution<int> checkerboard(0, arraysize(checkerboards) - 1);
+
+  for (int i = 0; i < 300; i++) {
+    // Widths are picked so that dst is smaller than src.
+    int dst_width = dims[dim(rng_)];
+    int src_width = dims[dim(rng_)];
+    if (src_width < dst_width)
+      std::swap(dst_width, src_width);
+
+    // src_width is picked to preserve aspect ratio.
+    int dst_height = dims[dim(rng_)];
+    int src_height = static_cast<int>(
+        static_cast<int64>(src_width) * dst_height / dst_width);
+
+    int checkerboard_size = checkerboards[checkerboard(rng_)];
+
+    ASSERT_NO_FATAL_FAILURE(
+        DoResizeBilinearTest(&gpu_ops,
+            gfx::Size(src_width, src_height),  // Src size (larger)
+            gfx::Size(dst_width, dst_height),  // Dst size (smaller)
+            checkerboard_size)) << "Failed on iteration " << i;
+  }
+};
+
+// Exercises ResizeBilinear with random magnification cases where the
+// aspect ratio does not change.
+//
+// This test relies on an assertion that resizing preserves symmetry in the
+// image, but for the current implementation of ResizeBilinear, this does not
+// seem to be true (fails on NVIDIA Quadro 600; passes on
+// Intel Mobile 965 Express)
+TEST_P(AcceleratedSurfaceTransformerTest, FAILS_MagnifyUniform) {
+  SCOPED_TRACE(GetAdapterInfo());
+  SeedRandom("MagnifyUniform");
+
+  AcceleratedSurfaceTransformer gpu_ops;
+  ASSERT_TRUE(gpu_ops.Init(device()));
+
+  int dims[] = {63, 64, 65, 99, 127, 128, 129, 192, 255, 256, 257};
+  int checkerboards[] = {1, 2, 3, 9};
+  uniform_int_distribution<int> dim(0, arraysize(dims) - 1);
+  uniform_int_distribution<int> checkerboard(0, arraysize(checkerboards) - 1);
+
+  for (int i = 0; i < 50; i++) {
+    // Widths are picked so that b is smaller than a.
+    int dst_width = dims[dim(rng_)];
+    int src_width = dims[dim(rng_)];
+    if (dst_width < src_width)
+      std::swap(src_width, dst_width);
+
+    int dst_height = dims[dim(rng_)];
+    int src_height = static_cast<int>(
+        static_cast<int64>(src_width) * dst_height / dst_width);
+
+    int checkerboard_size = checkerboards[checkerboard(rng_)];
+
+    ASSERT_NO_FATAL_FAILURE(
+        DoResizeBilinearTest(&gpu_ops,
+            gfx::Size(src_width, src_height),  // Src size (smaller)
+            gfx::Size(dst_width, dst_height),  // Dst size (larger)
+            checkerboard_size)) << "Failed on iteration " << i;
+  }
+};
+
+namespace {
+
+// Used to suppress test on Windows versions prior to Vista.
+std::vector<int> WindowsVersionIfVistaOrBetter() {
+  std::vector<int> result;
+  if (base::win::GetVersion() >= base::win::VERSION_VISTA) {
+    result.push_back(base::win::GetVersion());
+  }
+  return result;
+}
+
+}  // namespace
+
+INSTANTIATE_TEST_CASE_P(VistaAndUp,
+                        AcceleratedSurfaceTransformerTest,
+                        ::testing::ValuesIn(WindowsVersionIfVistaOrBetter()));