Separate image processing logic from presentation logic.

ui/ui_unittests.gypi

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 {
   'targets': [
     {
       'target_name': 'ui_test_support',
       'type': 'static_library',
       'dependencies': [
@@ skipping 33 matching lines @@
       'dependencies': [
         '../base/base.gyp:base',
         '../base/base.gyp:test_support_base',
         '../build/temp_gyp/googleurl.gyp:googleurl',
         '../skia/skia.gyp:skia',
         '../testing/gmock.gyp:gmock',
         '../testing/gtest.gyp:gtest',
         '../third_party/icu/icu.gyp:icui18n',
         '../third_party/icu/icu.gyp:icuuc',
         '../third_party/libpng/libpng.gyp:libpng',
+        '../ui/surface/surface.gyp:surface',

[ncarter (slow), 2012/12/17 19:13:49]

I'm seeing a circular dependency error on the Mac trybots (though I don't quite
follow why). I'll fix this somehow.

[apatrick_chromium, 2012/12/17 21:30:44]

Still or does this fix it? There's a gyp-explain tool:

https://codereview.chromium.org/8672006/

I think you can run this on a mac to see what the dependency is:

python tools/gyp-explain.py surface

Or something along those lines. The internet knows how.

[ncarter (slow), 2012/12/17 23:48:46]

I think it's a circular dependency in the .gyp files, not in the targets.

Basically, surface.gyp depends on ui.gyp, and with my change ui_unittests.gypi
depends on surface.gyp, and  ui_unittests.gypi is included by ui.gyp.

None of the options I can think of are particularly appealing:
 - Create off a new unit test executable in surface.gyp?
 - Split ui_unittests out of ui.gyp?
 - Change ui/surface/surface.gyp, so that it's a .gypi included by ui.gyp?

The last of these options seems the most workable, but I dislike all three -- do
speak up if you have a better idea.

[apatrick_chromium, 2012/12/18 00:01:12]

Any of those three are okay I think. Do whichever one works :)

         'ui',
         'ui_resources',
         'ui_test_support',
       ],
       # iOS uses a small subset of ui. common_sources are the only files that
       # are built on iOS.
       'common_sources' : [
         'base/animation/animation_container_unittest.cc',
         'base/animation/animation_unittest.cc',
         'base/animation/multi_animation_unittest.cc',
@@ skipping 61 matching lines @@
         'gfx/canvas_unittest.cc',
         'gfx/codec/jpeg_codec_unittest.cc',
         'gfx/color_analysis_unittest.cc',
         'gfx/font_list_unittest.cc',
         'gfx/image/image_mac_unittest.mm',
         'gfx/image/image_util_unittest.cc',
         'gfx/platform_font_mac_unittest.mm',
         'gfx/render_text_unittest.cc',
         'gfx/transform_util_unittest.cc',
         'gfx/video_decode_acceleration_support_mac_unittest.mm',
+        'surface/accelerated_surface_transformer_win_unittest.cc'
       ],
       'include_dirs': [
         '../',
       ],
       'conditions': [
         ['OS!="ios"', {
           'sources' : ['<@(_all_sources)'],
           'includes': [
             'base/ime/ime_unittests.gypi',
           ],
@@ skipping 145 matching lines @@
           'variables': {
             'test_suite_name': 'ui_unittests',
             'input_shlib_path': '<(SHARED_LIB_DIR)/<(SHARED_LIB_PREFIX)ui_unittests<(SHARED_LIB_SUFFIX)',
           },
           'includes': [ '../build/apk_test.gypi' ],
         },
       ],
     }],
   ],
 }