Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Unified Diff: utils/pub/oauth2.dart

Issue 11464015: Revert "Stop working around issue 6984." (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Base files Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « utils/pub/io.dart ('k') | utils/tests/pub/oauth2_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: utils/pub/oauth2.dart
diff --git a/utils/pub/oauth2.dart b/utils/pub/oauth2.dart
index 954936a19fc9666e3abf3cb765113a86988aae25..c7a87fdea7603274411a40b0f716f48f566f88e6 100644
--- a/utils/pub/oauth2.dart
+++ b/utils/pub/oauth2.dart
@@ -166,11 +166,13 @@ Future<Client> _authorize() {
if (queryString == null) queryString = '';
response.statusCode = 302;
response.headers.set('location', 'http://pub.dartlang.org/authorized');
- response.outputStream.close();
- return grant.handleAuthorizationResponse(queryToMap(queryString));
- }).transform((client) {
+ return Futures.wait([
+ closeHttpResponse(request, response),
+ grant.handleAuthorizationResponse(queryToMap(queryString))
+ ]);
+ }).transform((results) {
server.close();
- return client;
+ return results[1];
}), completer);
});
server.listen('127.0.0.1', 0);
« no previous file with comments | « utils/pub/io.dart ('k') | utils/tests/pub/oauth2_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698