Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2874)

Unified Diff: build/common.gypi

Issue 11464012: [Android] Add support for labeling a build with a particular build id. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/app/breakpad_linux.cc » ('j') | chrome/browser/resources/about_version.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index a937b5a952d3ca2218d2f89f18678c274b3a9e68..6f3b5e0aa4ca71b603479bd2efdffbe1daa9202e 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -2861,12 +2861,10 @@
# Android-specific options; note that most are set above with Linux.
['OS=="android"', {
'variables': {
- # This is the id for the archived chrome symbols. Each build that
- # archives symbols is assigned an id which is then added to GYP_DEFINES.
- # This is written to the device log on crashes just prior to dropping a
- # tombstone. Tools can determine the location of the archived symbols
- # from the id.
- 'chrome_symbols_id%': '',
+ # This is a unique identifier for a given build. It's used for
+ # identifying various build artifacts corresponding to a particular
+ # build of chrome (e.g. where to find archived symbols).
+ 'chrome_build_id%': '',
'conditions': [
# Use shared stlport library when system one used.
# Figure this out early since it needs symbols from libgcc.a, so it
@@ -2953,7 +2951,7 @@
'__GNU_SOURCE=1', # Necessary for clone()
'USE_STLPORT=1',
'_STLP_USE_PTR_SPECIALIZATIONS=1',
- 'CHROME_SYMBOLS_ID="<(chrome_symbols_id)"',
+ 'CHROME_BUILD_ID="<(chrome_build_id)"',
],
'ldflags!': [
'-pthread', # Not supported by Android toolchain.
« no previous file with comments | « no previous file | chrome/app/breakpad_linux.cc » ('j') | chrome/browser/resources/about_version.html » ('J')

Powered by Google App Engine
This is Rietveld 408576698