Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Unified Diff: compiler/java/com/google/dart/compiler/parser/DartParser.java

Issue 11464004: Enabled reporting problems in some libraries. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: compiler/java/com/google/dart/compiler/parser/DartParser.java
diff --git a/compiler/java/com/google/dart/compiler/parser/DartParser.java b/compiler/java/com/google/dart/compiler/parser/DartParser.java
index ed137259283783b510100477d4f7c9137baa55dc..f9f770044882b8a2f30bac47008127b34d582d5f 100644
--- a/compiler/java/com/google/dart/compiler/parser/DartParser.java
+++ b/compiler/java/com/google/dart/compiler/parser/DartParser.java
@@ -346,12 +346,7 @@ public class DartParser extends CompletionHooksParserBase {
} else if (peekPseudoKeyword(0, INTERFACE_KEYWORD) && peek(1).equals(Token.IDENTIFIER)) {
consume(Token.IDENTIFIER);
isParsingInterface = true;
- // TODO(scheglov) remove after http://code.google.com/p/dart/issues/detail?id=6318
- if (!Elements.isCoreLibrarySource(source)
- && !Elements.isLibrarySource(source, "/isolate/isolate.dart")
- && !Elements.isLibrarySource(source, "crypto/crypto.dart")) {
- reportError(position(), ParserErrorCode.DEPRECATED_INTERFACE);
- }
+ reportError(position(), ParserErrorCode.DEPRECATED_INTERFACE);
node = done(parseClass());
} else if (peekPseudoKeyword(0, TYPEDEF_KEYWORD)
&& (peek(1).equals(Token.IDENTIFIER) || peek(1).equals(Token.VOID) || peek(1).equals(Token.AS))) {
@@ -1333,16 +1328,7 @@ public class DartParser extends CompletionHooksParserBase {
// report "abstract" warning after all other checks to don't hide error with warning
// we ignore problems if there was already reported problem after given position
if (modifiers.isAbstract()) {
- // TODO(scheglov) remove after http://code.google.com/p/dart/issues/detail?id=6322
- // TODO(scheglov) remove after http://code.google.com/p/dart/issues/detail?id=6323
- if (!Elements.isCoreLibrarySource(source)
- && !Elements.isLibrarySource(source, "html/dartium/html_dartium.dart")
- && !Elements.isLibrarySource(source, "/math/math.dart")
- && !Elements.isLibrarySource(source, "/io/io_runtime.dart")
- && !Elements.isLibrarySource(source, "/crypto/crypto.dart")
- && !Elements.isLibrarySource(source, "/utf/utf.dart")) {
- reportError(position(), ParserErrorCode.DEPRECATED_ABSTRACT_METHOD);
- }
+ reportError(position(), ParserErrorCode.DEPRECATED_ABSTRACT_METHOD);
}
if (modifiers.isFactory()) {
@@ -1749,10 +1735,7 @@ public class DartParser extends CompletionHooksParserBase {
if (modifiers.isGetter()) {
parametersInfo = new FormalParameters(new ArrayList<DartParameter>(), -1, -1);
if (peek(0) == Token.LPAREN) {
- // TODO(scheglov) remove after http://code.google.com/p/dart/issues/detail?id=6297
- if (!Elements.isHtmlLibrarySource(source)) {
- reportError(position(), ParserErrorCode.DEPRECATED_GETTER);
- }
+ reportError(position(), ParserErrorCode.DEPRECATED_GETTER);
parametersInfo = parseFormalParameterList();
}
} else {
@@ -5448,11 +5431,12 @@ public class DartParser extends CompletionHooksParserBase {
private void reportDeprecatedError(int position, ErrorCode errorCode) {
// TODO(scheglov) remove after http://code.google.com/p/dart/issues/detail?id=6508
- if (!Elements.isCoreLibrarySource(source) &&
- !Elements.isLibrarySource(source, "/isolate/isolate.dart")
+ if (
+ true
+ &&!Elements.isCoreLibrarySource(source)
+ && !Elements.isLibrarySource(source, "/isolate/isolate.dart")
&& !Elements.isLibrarySource(source, "/json/json.dart")
&& !Elements.isLibrarySource(source, "/math/math.dart")
- && !Elements.isLibrarySource(source, "/html/dartium/nativewrappers.dart")
&& !Elements.isLibrarySource(source, "/io/io.dart")
&& !Elements.isLibrarySource(source, "/crypto/crypto.dart")
&& !Elements.isLibrarySource(source, "/uri/uri.dart")

Powered by Google App Engine
This is Rietveld 408576698