Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Issue 1146393004: Revert of Oilpan: Unpoison orphaned large objects before zapping (Closed)

Created:
5 years, 7 months ago by sof
Modified:
5 years, 7 months ago
CC:
blink-reviews, oilpan-reviews, kouhei+heap_chromium.org, Mads Ager (chromium)
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Revert of Oilpan: Unpoison orphaned large objects before zapping (patchset #3 id:40001 of https://codereview.chromium.org/1154733002/) Reason for revert: Broke ASAN compilation, http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20ASAN/builds/18648 Original issue's description: > Oilpan: Unpoison orphaned large objects before zapping > > To zap orphaned large objects, we need to unpoison the area. > Otherwise ASan detects the error, although it seems there has been > no orphaned large objects so far (by accident). > > We're already doing that for orphaned normal pages. > > This CL also adds a couple of ASSERTs that would be helpful. > > BUG=420515 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195782 TBR=oilpan-reviews@chromium.org,keishi@chromium.org,haraken@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=420515 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195783

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -18 lines) Patch
M Source/platform/heap/Heap.cpp View 5 chunks +8 lines, -18 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
sof
Created Revert of Oilpan: Unpoison orphaned large objects before zapping
5 years, 7 months ago (2015-05-22 13:02:00 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1146393004/1
5 years, 7 months ago (2015-05-22 13:02:18 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=195783
5 years, 7 months ago (2015-05-22 13:02:54 UTC) #3
haraken
5 years, 7 months ago (2015-05-22 13:20:14 UTC) #4
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698