LayoutTests/fast/dom/Attr/update-attribute-node-null-value-no-crash.html - Issue 1146393003: Make Attr.value/nodeValue/textContent not nullable

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/dom/Attr/update-attribute-node-null-value-no-crash.html

Issue 1146393003: Make Attr.value/nodeValue/textContent not nullable (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Add [TreatNullAs=EmptyString] to Attr.nodeValue/textContent Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
	(Empty)
1 <!DOCTYPE HTML>

2 <html>

3 <head>

4 <script src="../../../resources/js-test.js"></script>

5 </head>

6 <body>

7 <script>

8 description("Updating value of an attached Attr node having a null value");

9

10 var element = document.createElement("div");

11 var attr = document.createAttribute("nullable");

12 shouldBeEmptyString("attr.value");

13 shouldBeNull("attr.value = null; attr.value");

14 shouldBeNull("element.setAttributeNode(attr);");

15 shouldBeNull("element.getAttribute('nullable');");

16 shouldBeEqualToString("attr.value = 'noCrash'; attr.value", "noCrash");

17 shouldBeEqualToString("element.getAttribute('nullable')", "noCrash");

18 shouldBeNull("attr.value = null; attr.value");

19 shouldBeNull("element.getAttribute('nullable')");

20 </script>

21 </body>

22 </html>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/fast/dom/Attr/update-attribute-node-null-value-no-crash-expected.txt » ('j') | no next file with comments »