Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 1146393002: [turbofan] Fix UnifyReturn magic in the inliner. (Closed)

Created:
5 years, 7 months ago by Benedikt Meurer
Modified:
5 years, 7 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Fix UnifyReturn magic in the inliner. The inliner previously assumed that there will only be returns reaching the end node, but that's not true. This refactoring will make it possible to also hook up Deoptimize, Throw and Terminate nodes reaching end properly. R=mstarzinger@chromium.org Committed: https://crrev.com/1dbe83d9fbff359a0fda2c39dcf892989c72ab63 Cr-Commit-Position: refs/heads/master@{#28550}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -107 lines) Patch
M src/compiler/js-inlining.h View 2 chunks +1 line, -2 lines 0 comments Download
M src/compiler/js-inlining.cc View 6 chunks +58 lines, -105 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Benedikt Meurer
5 years, 7 months ago (2015-05-21 12:28:56 UTC) #1
Benedikt Meurer
Hey Michi, As discussed, step 1 of N to fix inlining wrt. Throw, Terminate and ...
5 years, 7 months ago (2015-05-21 12:29:58 UTC) #2
Michael Starzinger
LGTM.
5 years, 7 months ago (2015-05-21 12:34:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1146393002/1
5 years, 7 months ago (2015-05-21 12:34:41 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-21 13:02:24 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-21 13:02:34 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1dbe83d9fbff359a0fda2c39dcf892989c72ab63
Cr-Commit-Position: refs/heads/master@{#28550}

Powered by Google App Engine
This is Rietveld 408576698