Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(448)

Side by Side Diff: Source/core/frame/DOMWindowProperty.h

Issue 1146353002: Oilpan: insist on eager sweeping for some objects. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: add some limited-lifetime comments Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | Source/platform/LifecycleObserver.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google, Inc. All Rights Reserved. 2 * Copyright (C) 2011 Google, Inc. All Rights Reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 25 matching lines...) Expand all
36 36
37 class CORE_EXPORT DOMWindowProperty : public WillBeGarbageCollectedMixin { 37 class CORE_EXPORT DOMWindowProperty : public WillBeGarbageCollectedMixin {
38 public: 38 public:
39 explicit DOMWindowProperty(LocalFrame*); 39 explicit DOMWindowProperty(LocalFrame*);
40 40
41 virtual void willDestroyGlobalObjectInFrame(); 41 virtual void willDestroyGlobalObjectInFrame();
42 virtual void willDetachGlobalObjectFromFrame(); 42 virtual void willDetachGlobalObjectFromFrame();
43 43
44 LocalFrame* frame() const { return m_frame; } 44 LocalFrame* frame() const { return m_frame; }
45 45
46 // TODO(Oilpan): remove eager sweeping once DOMWindowProperty is
47 // always on the heap.
48 EAGERLY_SWEEP();
46 DECLARE_VIRTUAL_TRACE(); 49 DECLARE_VIRTUAL_TRACE();
47 50
48 protected: 51 protected:
49 // TODO(Oilpan): when ~DOMWindowProperty is removed, check classes that deri ve 52 // TODO(Oilpan): when ~DOMWindowProperty is removed, check classes that deri ve
50 // from it. Several will then be able to derive from GarbageCollected<> inst ead. 53 // from it. Several will then be able to derive from GarbageCollected<> inst ead.
51 #if !ENABLE(OILPAN) 54 #if !ENABLE(OILPAN)
52 virtual ~DOMWindowProperty(); 55 virtual ~DOMWindowProperty();
53 #endif 56 #endif
54 57
55 RawPtrWillBeMember<LocalFrame> m_frame; 58 RawPtrWillBeMember<LocalFrame> m_frame;
56 59
57 #if !ENABLE(OILPAN) 60 #if !ENABLE(OILPAN)
58 private: 61 private:
59 LocalDOMWindow* m_associatedDOMWindow; 62 LocalDOMWindow* m_associatedDOMWindow;
60 #endif 63 #endif
61 }; 64 };
62 65
63 } // namespace blink 66 } // namespace blink
64 67
65 #endif 68 #endif // DOMWindowProperty_h
OLDNEW
« no previous file with comments | « no previous file | Source/platform/LifecycleObserver.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698