Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(146)

Issue 1146313005: Remove unneeded 1px vertical offset for left/right double box sides (Closed)

Created:
4 years, 11 months ago by f(malita)
Modified:
4 years, 11 months ago
CC:
blink-reviews, blink-reviews-paint_chromium.org, dshwang, slimming-paint-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Remove unneeded 1px vertical offset for left/right double box sides Not only unneeded, but also causing corner artifacts in some cases. R=chrishtr@chromium.org,junov@chromium.org BUG=473119 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196261

Patch Set 1 #

Patch Set 2 : expectations #

Patch Set 3 : expectations #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -5 lines) Patch
M LayoutTests/TestExpectations View 1 2 1 chunk +12 lines, -0 lines 0 comments Download
M Source/core/paint/ObjectPainter.cpp View 1 chunk +2 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
f(malita)
A handful of trivial/expected layout test diffs: https://storage.googleapis.com/chromium-layout-test-archives/linux_blink_rel/64087/layout-test-results/results.html
4 years, 11 months ago (2015-06-01 20:10:09 UTC) #2
chrishtr
lgtm
4 years, 11 months ago (2015-06-01 20:19:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1146313005/40001
4 years, 11 months ago (2015-06-01 20:20:39 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1146313005/40001
4 years, 11 months ago (2015-06-01 23:34:12 UTC) #8
commit-bot: I haz the power
4 years, 11 months ago (2015-06-02 00:37:07 UTC) #9
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196261

Powered by Google App Engine
This is Rietveld 408576698