Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Unified Diff: tests/standalone/io/file_test.dart

Issue 1146283006: Close files used in some tests (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/standalone/io/file_test.dart
diff --git a/tests/standalone/io/file_test.dart b/tests/standalone/io/file_test.dart
index f2423467d8876d6fe23d1a8be12fd6c34b3e346e..0519b9243941d1acbc2f495b4cb99dbb2e0ff9d1 100644
--- a/tests/standalone/io/file_test.dart
+++ b/tests/standalone/io/file_test.dart
@@ -743,6 +743,8 @@ class FileTest {
await read(2, 3, 1, [null, null, 1]);
await read(0, 0, 0, [null, null, null]);
+ await openedFile.close();
+
asyncTestDone("testReadInto");
}
@@ -771,6 +773,8 @@ class FileTest {
read(1, 3, 2, [null, 1, 2]);
read(2, 3, 1, [null, null, 1]);
read(0, 0, 0, [null, null, null]);
+
+ openedFile.closeSync();
}
static testWriteFrom() async {
@@ -797,6 +801,9 @@ class FileTest {
var bytesFromFile = await file.readAsBytes();
Expect.listEquals(result, bytesFromFile);
+
+ await openedFile.close();
+
asyncTestDone("testWriteFrom");
}
@@ -821,6 +828,8 @@ class FileTest {
var bytesFromFile = file.readAsBytesSync();
Expect.listEquals(result, bytesFromFile);
+
+ openedFile.closeSync();
}
// Tests exception handling after file was closed.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698