content/browser/service_worker/service_worker_controllee_request_handler.h - Issue 1146253004: Add workerReady timing for ServiceWorker controlled requests [2/3]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_controllee_request_handler.h

Issue 1146253004: Add workerReady timing for ServiceWorker controlled requests [2/3] (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/service_worker/service_worker_context_request_handler.h ('K') | « content/browser/service_worker/service_worker_context_request_handler.cc ('k') | content/browser/service_worker/service_worker_controllee_request_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_controllee_request_handler.h

diff --git a/content/browser/service_worker/service_worker_controllee_request_handler.h b/content/browser/service_worker/service_worker_controllee_request_handler.h

index 1de2bf9ba26ab946b850ae2f1e8115920e22165f..90b01f99e529a82abe266658c16ee263a09294dc 100644

--- a/content/browser/service_worker/service_worker_controllee_request_handler.h

+++ b/content/browser/service_worker/service_worker_controllee_request_handler.h

@@ -49,12 +49,7 @@ class CONTENT_EXPORT ServiceWorkerControlleeRequestHandler

net::NetworkDelegate* network_delegate,

ResourceContext* resource_context) override;

- void GetExtraResponseInfo(

- bool* was_fetched_via_service_worker,

- bool* was_fallback_required_by_service_worker,

- GURL* original_url_via_service_worker,

- blink::WebServiceWorkerResponseType* response_type_via_service_worker,

- base::TimeTicks* worker_start_time) const override;

+ void GetExtraResponseInfo(ResourceResponseInfo* response_info) const override;

private:

FRIEND_TEST_ALL_PREFIXES(ServiceWorkerControlleeRequestHandlerTest,

@@ -83,6 +78,7 @@ class CONTENT_EXPORT ServiceWorkerControlleeRequestHandler

ResourceContext* resource_context_;

GURL stripped_url_;

base::TimeTicks worker_start_time_;

+ base::TimeTicks worker_ready_time_;

base::WeakPtrFactory<ServiceWorkerControlleeRequestHandler> weak_factory_;

DISALLOW_COPY_AND_ASSIGN(ServiceWorkerControlleeRequestHandler);