Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(543)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1146243003: Update Clang ToT iOS builder to use the 8.3 SDK (Closed)

Created:
5 years, 7 months ago by smut
Modified:
5 years, 7 months ago
Reviewers:
hans
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update Clang ToT iOS builder to use the 8.3 SDK BUG=452726 Committed: https://crrev.com/d4c266ca63732a404d492301e4af29f643fedab1 Cr-Commit-Position: refs/heads/master@{#330821}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M ios/build/bots/chromium.fyi/ClangToTiOS.json View 2 chunks +3 lines, -3 lines 2 comments Download

Messages

Total messages: 7 (2 generated)
smut
https://codereview.chromium.org/1146243003/diff/1/ios/build/bots/chromium.fyi/ClangToTiOS.json File ios/build/bots/chromium.fyi/ClangToTiOS.json (right): https://codereview.chromium.org/1146243003/diff/1/ios/build/bots/chromium.fyi/ClangToTiOS.json#newcode20 ios/build/bots/chromium.fyi/ClangToTiOS.json:20: "sdk": "iphoneos8.3", FYI simulator would cycle faster. To use ...
5 years, 7 months ago (2015-05-20 21:33:57 UTC) #2
hans
LGTM https://codereview.chromium.org/1146243003/diff/1/ios/build/bots/chromium.fyi/ClangToTiOS.json File ios/build/bots/chromium.fyi/ClangToTiOS.json (right): https://codereview.chromium.org/1146243003/diff/1/ios/build/bots/chromium.fyi/ClangToTiOS.json#newcode20 ios/build/bots/chromium.fyi/ClangToTiOS.json:20: "sdk": "iphoneos8.3", On 2015/05/20 21:33:56, smut wrote: > ...
5 years, 7 months ago (2015-05-20 21:36:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1146243003/1
5 years, 7 months ago (2015-05-20 21:39:08 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-20 22:37:50 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-20 22:39:36 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/d4c266ca63732a404d492301e4af29f643fedab1
Cr-Commit-Position: refs/heads/master@{#330821}

Powered by Google App Engine
This is Rietveld 408576698