Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(395)

Unified Diff: ios/web/crw_browsing_data_store_unittest.mm

Issue 1146223012: Cleaning up CRWBrowsingDataMode (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/web/crw_browsing_data_store.mm ('k') | ios/web/public/crw_browsing_data_store.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/web/crw_browsing_data_store_unittest.mm
diff --git a/ios/web/crw_browsing_data_store_unittest.mm b/ios/web/crw_browsing_data_store_unittest.mm
index 60563d8ed105dd0e6e9c94c530d0da565eb12230..a5d22c11e740d784fce458d6c338b9667e729a2a 100644
--- a/ios/web/crw_browsing_data_store_unittest.mm
+++ b/ios/web/crw_browsing_data_store_unittest.mm
@@ -158,29 +158,29 @@ TEST_F(BrowsingDataStoreTest, MakeActiveAndInactiveOperations) {
id unsucessfullCallback = ^(BOOL success) {
ASSERT_TRUE([NSThread isMainThread]);
- CRWBrowsingDataStoreMode mode = [browsing_data_store_ mode];
+ web::BrowsingDataStoreMode mode = [browsing_data_store_ mode];
Eugene But (OOO till 7-30) 2015/06/04 15:42:59 Drop web:: this code is already in web namespace.
shreyasv1 2015/06/05 21:05:51 Done.
EXPECT_FALSE(success);
- EXPECT_EQ(SYNCHRONIZING, mode);
+ EXPECT_EQ(CHANGING, mode);
};
[browsing_data_store_ makeActiveWithCompletionHandler:unsucessfullCallback];
- EXPECT_EQ(SYNCHRONIZING, [browsing_data_store_ mode]);
+ EXPECT_EQ(CHANGING, [browsing_data_store_ mode]);
EXPECT_EQ(1U, [observer modeChangeCount]);
[browsing_data_store_ makeInactiveWithCompletionHandler:unsucessfullCallback];
- EXPECT_EQ(SYNCHRONIZING, [browsing_data_store_ mode]);
+ EXPECT_EQ(CHANGING, [browsing_data_store_ mode]);
[browsing_data_store_ makeActiveWithCompletionHandler:unsucessfullCallback];
- EXPECT_EQ(SYNCHRONIZING, [browsing_data_store_ mode]);
+ EXPECT_EQ(CHANGING, [browsing_data_store_ mode]);
__block BOOL block_was_called = NO;
[browsing_data_store_ makeInactiveWithCompletionHandler:^(BOOL success) {
ASSERT_TRUE([NSThread isMainThread]);
- CRWBrowsingDataStoreMode mode = [browsing_data_store_ mode];
+ web::BrowsingDataStoreMode mode = [browsing_data_store_ mode];
Eugene But (OOO till 7-30) 2015/06/04 15:42:58 ditto
shreyasv1 2015/06/05 21:05:51 Done.
EXPECT_TRUE(success);
EXPECT_EQ(INACTIVE, mode);
block_was_called = YES;
}];
- EXPECT_EQ(SYNCHRONIZING, [browsing_data_store_ mode]);
+ EXPECT_EQ(CHANGING, [browsing_data_store_ mode]);
base::test::ios::WaitUntilCondition(^bool{
return block_was_called;
« no previous file with comments | « ios/web/crw_browsing_data_store.mm ('k') | ios/web/public/crw_browsing_data_store.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698