Issue 1146193005: [bindings] Use |PostMessage| attribute for Worker.postMessage to eliminate custom bindings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1146193005: [bindings] Use |PostMessage| attribute for Worker.postMessage to eliminate custom bindings (Closed)

Created:
5 years, 7 months ago by vivekg_samsung

Modified:
5 years, 7 months ago

Reviewers:
haraken, vivekg

CC:
vivekg, arv+blink, blink-reviews, blink-reviews-bindings_chromium.org, Inactive, falken, horo+watch_chromium.org, kinuko+worker_chromium.org, vivekg_samsung

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

[bindings] Use |PostMessage| attribute for Worker.postMessage to eliminate custom bindings BUG=345519 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195883

Patch Set 1 #

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1 line, -47 lines)			Patch
D	Source/bindings/core/v8/custom/V8WorkerCustom.cpp	View	1 chunk	+0 lines, -45 lines	0 comments	Download
M	Source/bindings/core/v8/custom/custom.gypi	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/core/workers/Worker.idl	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 7 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

haraken

Don't you need to remove the file from custom.gni as well?

5 years, 7 months ago (2015-05-26 01:58:52 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1146193005/1

5 years, 7 months ago (2015-05-26 02:09:30 UTC) #6

commit-bot: I haz the power

5 years, 7 months ago (2015-05-26 02:55:36 UTC) #7

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=195883

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages