Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Issue 1146193002: Revert of Add SyncScheduler for scheduling CryptAuth enrollments and syncing devices. (Closed)

Created:
5 years, 7 months ago by eugenis
Modified:
5 years, 7 months ago
Reviewers:
Tim Song, Ilya Sherman
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add SyncScheduler for scheduling CryptAuth enrollments and syncing devices. (patchset #3 id:80001 of https://codereview.chromium.org/1147563002/) Reason for revert: MSan and Valgrind failures (use-of-uninitialized memory). Original issue's description: > Add SyncScheduler for scheduling CryptAuth enrollments and syncing devices. > > BUG=420315 > TEST=unit test > > Committed: https://crrev.com/27e044cfc5c2a43b6c575508aca64763bfa2deba > Cr-Commit-Position: refs/heads/master@{#330713} TBR=isherman@chromium.org,tengs@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=420315 Committed: https://crrev.com/917821a054626f8e445ebcbc9e93687d79e51842 Cr-Commit-Position: refs/heads/master@{#330780}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -706 lines) Patch
M components/components_tests.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M components/proximity_auth.gypi View 1 chunk +0 lines, -4 lines 0 comments Download
M components/proximity_auth/cryptauth/BUILD.gn View 2 chunks +0 lines, -5 lines 0 comments Download
D components/proximity_auth/cryptauth/sync_scheduler.h View 1 chunk +0 lines, -95 lines 0 comments Download
D components/proximity_auth/cryptauth/sync_scheduler.cc View 1 chunk +0 lines, -31 lines 0 comments Download
D components/proximity_auth/cryptauth/sync_scheduler_impl.h View 1 chunk +0 lines, -101 lines 0 comments Download
D components/proximity_auth/cryptauth/sync_scheduler_impl.cc View 1 chunk +0 lines, -191 lines 0 comments Download
D components/proximity_auth/cryptauth/sync_scheduler_impl_unittest.cc View 1 chunk +0 lines, -278 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
eugenis
Created Revert of Add SyncScheduler for scheduling CryptAuth enrollments and syncing devices.
5 years, 7 months ago (2015-05-20 18:55:42 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1146193002/1
5 years, 7 months ago (2015-05-20 18:56:26 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-20 18:57:55 UTC) #3
commit-bot: I haz the power
5 years, 7 months ago (2015-05-20 18:58:50 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/917821a054626f8e445ebcbc9e93687d79e51842
Cr-Commit-Position: refs/heads/master@{#330780}

Powered by Google App Engine
This is Rietveld 408576698