Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(394)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1146173007: [KeyboardEvent] Cleanup of dispatchKeyEvent (Closed)

Created:
5 years, 6 months ago by Habib Virji
Modified:
5 years, 6 months ago
Reviewers:
dgozman
CC:
chromium-reviews, darin-cc_chromium.org, jam, yurys, pfeldman, devtools-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@bug227231_devTools
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[KeyboardEvent] Cleanup of dispatchKeyEvent dispatchKeyEvent cleanup of removing a old function. BUG=227231 R=dgozman Committed: https://crrev.com/f7200bfe70d4d87eeb60ca143c9d56b7cf3251c5 Cr-Commit-Position: refs/heads/master@{#332813}

Patch Set 1 #

Patch Set 2 : Rebaselined #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -33 lines) Patch
M content/browser/devtools/protocol/input_handler.h View 1 chunk +0 lines, -13 lines 0 comments Download
M content/browser/devtools/protocol/input_handler.cc View 1 1 chunk +0 lines, -20 lines 0 comments Download

Messages

Total messages: 16 (5 generated)
Habib Virji
This patch is intended to land after chromium side and blink side changes land.
5 years, 6 months ago (2015-06-02 12:51:50 UTC) #1
dgozman
This one needs rebaseline now.
5 years, 6 months ago (2015-06-02 15:26:14 UTC) #2
Habib Virji
On 2015/06/02 15:26:14, dgozman wrote: > This one needs rebaseline now. Done please have a ...
5 years, 6 months ago (2015-06-02 16:59:45 UTC) #3
dgozman
lgtm
5 years, 6 months ago (2015-06-02 18:12:35 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1146173007/20001
5 years, 6 months ago (2015-06-03 08:47:28 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_rel/builds/94137)
5 years, 6 months ago (2015-06-03 09:15:20 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1146173007/20001
5 years, 6 months ago (2015-06-03 10:47:20 UTC) #10
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_rel/builds/94156)
5 years, 6 months ago (2015-06-03 11:00:12 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1146173007/20001
5 years, 6 months ago (2015-06-04 09:47:55 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-04 10:48:41 UTC) #15
commit-bot: I haz the power
5 years, 6 months ago (2015-06-04 10:49:39 UTC) #16
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/f7200bfe70d4d87eeb60ca143c9d56b7cf3251c5
Cr-Commit-Position: refs/heads/master@{#332813}

Powered by Google App Engine
This is Rietveld 408576698