Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issue 1146173005: [test] Refactor call-tester to use c-signature.h. (Closed)

Created:
5 years, 6 months ago by titzer
Modified:
5 years, 6 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[test] Refactor call-tester to use c-signature.h. R=mstarzinger@chromium.org BUG= Committed: https://crrev.com/2c3e35120f245ec1f116842f475116478317d1d5 Cr-Commit-Position: refs/heads/master@{#28763}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -114 lines) Patch
M test/cctest/compiler/c-signature.h View 1 2 1 chunk +32 lines, -3 lines 0 comments Download
M test/cctest/compiler/call-tester.h View 2 chunks +8 lines, -59 lines 0 comments Download
M test/cctest/compiler/codegen-tester.h View 2 chunks +4 lines, -25 lines 0 comments Download
M test/cctest/compiler/graph-builder-tester.h View 3 chunks +4 lines, -27 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
titzer
5 years, 6 months ago (2015-06-02 11:11:24 UTC) #1
Michael Starzinger
LGTM.
5 years, 6 months ago (2015-06-02 11:45:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1146173005/40001
5 years, 6 months ago (2015-06-02 14:59:29 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 6 months ago (2015-06-02 15:01:00 UTC) #6
commit-bot: I haz the power
5 years, 6 months ago (2015-06-02 15:01:15 UTC) #7
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/2c3e35120f245ec1f116842f475116478317d1d5
Cr-Commit-Position: refs/heads/master@{#28763}

Powered by Google App Engine
This is Rietveld 408576698