Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1724)

Unified Diff: Source/modules/bluetooth/BluetoothGATTService.idl

Issue 1146163005: bluetooth: Blink-side implementation of getCharacteristic. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@bluetooth-characteristic-interface
Patch Set: getCharacteristic Blink-Side Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/bluetooth/BluetoothGATTService.idl
diff --git a/Source/modules/bluetooth/BluetoothGATTService.idl b/Source/modules/bluetooth/BluetoothGATTService.idl
index ee3037cefddf9f6e441172a10ec8c618f7fbbba5..439d3457b715f43b3adcfae1606a58d9472e1972 100644
--- a/Source/modules/bluetooth/BluetoothGATTService.idl
+++ b/Source/modules/bluetooth/BluetoothGATTService.idl
@@ -6,6 +6,7 @@
// Implement BluetoothGATTService interface: https://crbug.com/483342
+typedef DOMString BluetoothCharacteristicUUID;
Jeffrey Yasskin 2015/06/03 00:24:04 Add the same TODO here as you have in GATTRemoteSe
ortuno 2015/06/03 21:57:04 I have another patch where I implemented some of B
Jeffrey Yasskin 2015/06/03 23:22:52 Oh, fun.
typedef DOMString UUID;
[
@@ -15,7 +16,7 @@ typedef DOMString UUID;
readonly attribute UUID uuid;
readonly attribute boolean isPrimary;
// readonly attribute BluetoothDevice device;
- // Promise<BluetoothGATTCharacteristic> getCharacteristic(BluetoothCharacteristicUUID characteristic);
+ [CallWith=ScriptState] Promise<BluetoothGATTCharacteristic> getCharacteristic(BluetoothCharacteristicUUID characteristic);
// Promise<sequence<BluetoothGATTCharacteristic>> getCharacteristics(optional BluetoothCharacteristicUUID characteristic);
// Promise<BluetoothGATTService> getIncludedService(BluetoothServiceUUID service);
// Promise<sequence<BluetoothGATTService>> getIncludedServices(optional BluetoothServiceUUID service);

Powered by Google App Engine
This is Rietveld 408576698