Issue 1146163002: Revert "Revert multiple commits:"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1146163002: Revert "Revert multiple commits:" (Closed)

Created:
5 years, 7 months ago by viettrungluu

Modified:
5 years, 7 months ago

Reviewers:
yzshen1

CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Revert "Revert multiple commits:" This reverts commit ea126fd4aaca5aa2bbdf799365558fe5e6df4909. Also fix Scoped*IPCSupport: I guess I shouldn't have things call virtual methods before vtables are initialized. D'oh. Thus replace ScopedIPCSupportBase with ScopedIPCSupportHelper. R=yzshen@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/2cf874c6ef872c3240b734296bc3c13c68422e48

Patch Set 1 #

Patch Set 2 : the fix #

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+503 lines, -71 lines)			Patch
M	mojo/edk/embedder/embedder.h	View		2 chunks	+36 lines, -8 lines	0 comments	Download
M	mojo/edk/embedder/embedder.cc	View		1 chunk	+38 lines, -3 lines	0 comments	Download
M	mojo/edk/embedder/embedder_unittest.cc	View		5 chunks	+82 lines, -2 lines	0 comments	Download
M	mojo/edk/system/connection_manager_unittest.cc	View		15 chunks	+102 lines, -27 lines	0 comments	Download
M	mojo/edk/system/master_connection_manager.h	View		3 chunks	+18 lines, -3 lines	0 comments	Download
M	mojo/edk/system/master_connection_manager.cc	View		3 chunks	+39 lines, -11 lines	0 comments	Download
M	mojo/edk/test/multiprocess_test_helper.h	View		1 chunk	+6 lines, -0 lines	0 comments	Download
M	mojo/edk/test/multiprocess_test_helper.cc	View		2 chunks	+15 lines, -0 lines	0 comments	Download
M	mojo/edk/test/scoped_ipc_support.h	View	1	1 chunk	+80 lines, -7 lines	0 comments	Download
M	mojo/edk/test/scoped_ipc_support.cc	View	1	2 chunks	+87 lines, -10 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

viettrungluu

5 years, 7 months ago (2015-05-20 18:18:09 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
2cf874c6ef872c3240b734296bc3c13c68422e48 (presubmit successful).

Expand Messages | Collapse Messages