sdk/lib/_internal/compiler/implementation/ssa/builder.dart - Issue 114613003: double * int returns a double can be simplified to an int if both operands are constants. Therefore…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/ssa/builder.dart

Issue 114613003: double * int returns a double can be simplified to an int if both operands are constants. Therefore… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: sdk/lib/_internal/compiler/implementation/ssa/builder.dart

===================================================================

--- sdk/lib/_internal/compiler/implementation/ssa/builder.dart (revision 31217)

+++ sdk/lib/_internal/compiler/implementation/ssa/builder.dart (working copy)

@@ -3107,7 +3107,11 @@

// does not look at elements in the list.

TypeMask type =

TypeMaskFactory.inferredTypeForElement(element, compiler);

- if (!type.containsAll(compiler)) instruction.instructionType = type;

+ if (!type.containsAll(compiler)) {

+ // TODO(13429): The inferrer should know that an element

+ // cannot be null.

+ instruction.instructionType = type.nonNullable();

+ }

} else if (element.isField() && isLazilyInitialized(element)) {

HInstruction instruction = new HLazyStatic(

element,

« no previous file with comments | « no previous file | sdk/lib/_internal/compiler/implementation/ssa/nodes.dart » ('j') | no next file with comments »