Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 1146123003: Move simple_render_tree into tests as render_flex (Closed)

Created:
5 years, 6 months ago by abarth-chromium
Modified:
5 years, 6 months ago
Reviewers:
Hixie
CC:
gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : now with expected.txt #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -82 lines) Patch
D sky/examples/raw/simple_render_tree.dart View 1 chunk +0 lines, -76 lines 0 comments Download
M sky/sdk/lib/framework/layout2.dart View 1 chunk +5 lines, -5 lines 0 comments Download
A sky/tests/raw/render_flex.dart View 1 chunk +85 lines, -0 lines 0 comments Download
A + sky/tests/raw/render_flex-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
abarth-chromium
5 years, 6 months ago (2015-05-28 21:05:55 UTC) #1
Hixie
lgtm
5 years, 6 months ago (2015-05-28 21:28:11 UTC) #2
abarth-chromium
5 years, 6 months ago (2015-05-28 21:29:14 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
6e28fccb50785731ebb16a65e7421d5c83e266b6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698