Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 1146123002: Remove unused libpeerconnection code. (Closed)

Created:
5 years, 7 months ago by tommi (sloooow) - chröme
Modified:
5 years, 7 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused libpeerconnection code. This removes boilerplate code that was used when we supported building libpeerconnection as a shared library. We don't support that any longer, so it's safe to delete. BUG=463660 Committed: https://crrev.com/de10703ec87eaa04f36f61697cc73e15bcf7d4cc Cr-Commit-Position: refs/heads/master@{#330783}

Patch Set 1 #

Patch Set 2 : revert a couple of libjingle.gyp changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -428 lines) Patch
M third_party/libjingle/libjingle.gyp View 1 1 chunk +0 lines, -2 lines 0 comments Download
D third_party/libjingle/overrides/allocator_shim/allocator_proxy.cc View 1 chunk +0 lines, -27 lines 0 comments Download
D third_party/libjingle/overrides/allocator_shim/allocator_stub.h View 1 chunk +0 lines, -24 lines 0 comments Download
D third_party/libjingle/overrides/allocator_shim/allocator_stub.cc View 1 chunk +0 lines, -17 lines 0 comments Download
M third_party/libjingle/overrides/init_webrtc.h View 1 chunk +3 lines, -76 lines 0 comments Download
M third_party/libjingle/overrides/init_webrtc.cc View 5 chunks +8 lines, -114 lines 0 comments Download
D third_party/libjingle/overrides/initialize_module.cc View 1 chunk +0 lines, -147 lines 0 comments Download
D third_party/libjingle/overrides/talk/media/webrtc/webrtcexport.h View 1 chunk +0 lines, -21 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
tommi (sloooow) - chröme
5 years, 7 months ago (2015-05-20 15:27:43 UTC) #2
kjellander_chromium
hmm, I'm going to let you work out the compilation errors first.
5 years, 7 months ago (2015-05-20 16:02:05 UTC) #3
tommi (sloooow) - chröme
revert a couple of libjingle.gyp changes
5 years, 7 months ago (2015-05-20 16:28:26 UTC) #4
tommi (sloooow) - chröme
On 2015/05/20 at 16:28:26, tommi wrote: > revert a couple of libjingle.gyp changes I reverted ...
5 years, 7 months ago (2015-05-20 16:30:39 UTC) #5
kjellander_chromium
lgtm
5 years, 7 months ago (2015-05-20 17:29:22 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1146123002/20001
5 years, 7 months ago (2015-05-20 19:24:37 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-20 19:36:52 UTC) #9
commit-bot: I haz the power
5 years, 7 months ago (2015-05-20 19:37:41 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/de10703ec87eaa04f36f61697cc73e15bcf7d4cc
Cr-Commit-Position: refs/heads/master@{#330783}

Powered by Google App Engine
This is Rietveld 408576698