Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 1146113004: Fix ToNameArray (Closed)

Created:
5 years, 7 months ago by Toon Verwaest
Modified:
5 years, 7 months ago
Reviewers:
rossberg
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix ToNameArray BUG= Committed: https://crrev.com/eeb2d17b7ad4634c172539d449b987741ad235f0 Cr-Commit-Position: refs/heads/master@{#28580}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M src/v8natives.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/harmony/proxies-for.js View 1 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Toon Verwaest
PTAL
5 years, 7 months ago (2015-05-20 16:27:23 UTC) #2
rossberg
lgtm
5 years, 7 months ago (2015-05-20 17:30:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1146113004/20001
5 years, 7 months ago (2015-05-22 10:23:36 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-22 10:57:45 UTC) #7
commit-bot: I haz the power
5 years, 7 months ago (2015-05-22 10:58:01 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/eeb2d17b7ad4634c172539d449b987741ad235f0
Cr-Commit-Position: refs/heads/master@{#28580}

Powered by Google App Engine
This is Rietveld 408576698