Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 1146103003: X87: [strong] Function arity check should be based on required parameters (Closed)

Created:
5 years, 7 months ago by chunyang.dai
Modified:
5 years, 7 months ago
Reviewers:
Weiliang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [strong] Function arity check should be based on required parameters port 78f0452d310221ac74b6221140d376d8302c4579 (r28491) original commit message: Also check whether the arguments count is smaller than the number of required parameters which is the same as the SharedFunctionInfo length. BUG= Committed: https://crrev.com/5299d17733ab29377a86bd8569329c2ba29071e6 Cr-Commit-Position: refs/heads/master@{#28531}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -3 lines) Patch
M src/x87/builtins-x87.cc View 2 chunks +9 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
chunyang.dai
PTAL.
5 years, 7 months ago (2015-05-21 03:15:27 UTC) #2
Weiliang
lgtm
5 years, 7 months ago (2015-05-21 04:07:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1146103003/1
5 years, 7 months ago (2015-05-21 04:07:48 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-21 04:31:05 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-21 04:31:17 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5299d17733ab29377a86bd8569329c2ba29071e6
Cr-Commit-Position: refs/heads/master@{#28531}

Powered by Google App Engine
This is Rietveld 408576698