Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 1146103002: content: Close in-process discardable memory segments. (Closed)

Created:
5 years, 7 months ago by reveman
Modified:
5 years, 7 months ago
CC:
chromium-reviews, darin-cc_chromium.org, erikwright+watch_chromium.org, gavinp+memory_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

content: Close in-process discardable memory segments. This prevents in-process discardable shared memory instances from requiring an open file descriptor. BUG=489174 TEST=base_unittests --gtest_filter=DiscardableSharedMemory.Close Committed: https://crrev.com/6e909fedc6e1a613d1eb0637ddb82292c6c68741 Cr-Commit-Position: refs/heads/master@{#330806}

Patch Set 1 #

Patch Set 2 : close the host side too #

Patch Set 3 : fix comment typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -12 lines) Patch
M base/memory/discardable_shared_memory.h View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M base/memory/discardable_shared_memory.cc View 4 chunks +18 lines, -10 lines 0 comments Download
M base/memory/discardable_shared_memory_unittest.cc View 1 chunk +25 lines, -2 lines 0 comments Download
M content/common/host_discardable_shared_memory_manager.cc View 1 3 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
reveman
5 years, 7 months ago (2015-05-20 13:57:34 UTC) #2
Avi (use Gerrit)
lgtm
5 years, 7 months ago (2015-05-20 16:26:26 UTC) #3
reveman
+danakj
5 years, 7 months ago (2015-05-20 16:30:15 UTC) #5
danakj
LGTM
5 years, 7 months ago (2015-05-20 20:59:38 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1146103002/40001
5 years, 7 months ago (2015-05-20 21:06:59 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 7 months ago (2015-05-20 21:25:38 UTC) #10
commit-bot: I haz the power
5 years, 7 months ago (2015-05-20 21:27:02 UTC) #11
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/6e909fedc6e1a613d1eb0637ddb82292c6c68741
Cr-Commit-Position: refs/heads/master@{#330806}

Powered by Google App Engine
This is Rietveld 408576698