Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1130)

Unified Diff: scripts/slave/recipe_modules/v8/api.py

Issue 1146093002: Adding api option to download test data before a perf run. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | scripts/slave/recipe_modules/v8/example.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/slave/recipe_modules/v8/api.py
diff --git a/scripts/slave/recipe_modules/v8/api.py b/scripts/slave/recipe_modules/v8/api.py
index bc460de780912283130a89c026f1f62d687b13a4..1d16d36e3a2802b2d647c56553eccef8c2aab2e6 100644
--- a/scripts/slave/recipe_modules/v8/api.py
+++ b/scripts/slave/recipe_modules/v8/api.py
@@ -812,7 +812,7 @@ class V8Api(recipe_api.RecipeApi):
"""
results_mapping = collections.defaultdict(dict)
- def run_single_perf_test(test, name, json_file):
+ def run_single_perf_test(test, name, json_file, download_test=None):
"""Call the v8 perf test runner.
Performance results are saved in the json test results file as a dict with
@@ -832,6 +832,14 @@ class V8Api(recipe_api.RecipeApi):
self._test_data.get('perf_failures', False))
try:
+ if download_test is not None:
+ self.m.python(
+ '%s%s - download-data' % (name, suffix),
+ self.m.path['checkout'].join('tools', 'run-test.py'),
+ ['--download-data-only', download_test],
+ cwd=self.m.path['checkout'],
+ step_test_data=step_test_data,
+ )
self.m.python(
'%s%s' % (name, suffix),
self.m.path['checkout'].join('tools', 'run_perf.py'),
@@ -862,7 +870,8 @@ class V8Api(recipe_api.RecipeApi):
assert perf_configs[t]['json']
try:
run_single_perf_test(
- t, perf_configs[t]['name'], perf_configs[t]['json'])
+ t, perf_configs[t]['name'], perf_configs[t]['json'],
+ download_test=perf_configs[t].get('download_test'))
except self.m.step.StepFailure:
failed = True
« no previous file with comments | « no previous file | scripts/slave/recipe_modules/v8/example.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698